From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-option
Date: Thu, 8 Jul 2010 08:51:18 +0200 [thread overview]
Message-ID: <20100708065118.GA21565@pengutronix.de> (raw)
In-Reply-To: <7vr5jfrmuq.fsf@alter.siamese.dyndns.org>
On Wed, Jul 07, 2010 at 02:41:33PM -0700, Junio C Hamano wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
>
> > The ?: operator has a lower priority than |, so the implicit associativity
> > made the 6th argument of parse_options be PARSE_OPT_KEEP_DASHDASH if
> > keep_dashdash was true discarding PARSE_OPT_STOP_AT_NON_OPTION and
> > PARSE_OPT_SHELL_EVAL.
>
> Wow, this is an age-old breakage dating back to 6e0800e (parse-opt: make
> PARSE_OPT_STOP_AT_NON_OPTION available to git rev-parse, 2009-06-14) that
> dates back to the very original --stop-at-non-option patch, isn't it?
Yeah, the author of 6e0800e should get a pat on his head and a lesson in
C. :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-07-08 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 14:46 [PATCH] rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-option Uwe Kleine-König
2010-07-07 21:41 ` Junio C Hamano
2010-07-08 6:51 ` Uwe Kleine-König [this message]
2010-07-08 7:26 ` Uwe Kleine-König
2010-07-08 10:18 ` Pierre Habouzit
2010-07-08 12:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708065118.GA21565@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).