From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Bert Huijben <bert@qqmail.nl>,
dev@subversion.apache.org, 'Jonathan Nieder' <jrnieder@gmail.com>,
'Sverre Rabbelier' <srabbelier@gmail.com>,
'Git Mailing List' <git@vger.kernel.org>
Subject: Re: [PATCH] Add svnrdump
Date: Fri, 9 Jul 2010 15:43:18 +0200 [thread overview]
Message-ID: <20100709134318.GC12315@debian> (raw)
In-Reply-To: <alpine.561.2.00.1007081113210.3936@daniel2.local>
Hi Daniel,
Daniel Shahaf writes:
> > > + /* Use a temporary file to measure the text-content-length */
> > > + apr_err = apr_temp_dir_get(&tempdir, hb->pool);
>
> svn_io_temp_dir()
Fixed.
> > > + if (apr_err != APR_SUCCESS)
> > > + SVN_ERR(svn_error_wrap_apr(apr_err, NULL));
> > > +
> > > + hb->temp_filepath = apr_psprintf(eb->pool, "%s/svn-fe-XXXXXX",
> > > tempdir);
> >
>
> os.path.join()
>
> Err, I mean, svn_dirent_join().
Fixed. Thanks :)
-- Ram
next prev parent reply other threads:[~2010-07-09 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 8:35 [PATCH] Add svnrdump Ramkumar Ramachandra
2010-07-08 9:28 ` Bert Huijben
2010-07-08 8:17 ` Daniel Shahaf
2010-07-09 0:42 ` Blair Zajac
2010-07-09 8:16 ` Michael J Gruber
2010-07-09 12:40 ` Sverre Rabbelier
2010-07-09 16:51 ` Junio C Hamano
2010-07-09 13:43 ` Ramkumar Ramachandra [this message]
2010-07-09 13:42 ` Ramkumar Ramachandra
2010-07-09 14:17 ` Ramkumar Ramachandra
2010-07-09 13:46 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709134318.GC12315@debian \
--to=artagnon@gmail.com \
--cc=bert@qqmail.nl \
--cc=d.s@daniel.shahaf.name \
--cc=dev@subversion.apache.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).