git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Bert Huijben <bert@qqmail.nl>
Cc: dev@subversion.apache.org, 'Jonathan Nieder' <jrnieder@gmail.com>,
	'Sverre Rabbelier' <srabbelier@gmail.com>,
	'Git Mailing List' <git@vger.kernel.org>
Subject: Re: [PATCH] Add svnrdump
Date: Fri, 9 Jul 2010 15:46:00 +0200	[thread overview]
Message-ID: <20100709134600.GD12315@debian> (raw)
In-Reply-To: <002d01cb1e7f$e0ff03c0$a2fd0b40$@nl>

Hi,

Bert Huijben writes:
> > +  /* Cleanup */
> > +  SVN_ERR(svn_io_file_close(hb->temp_file, hb->pool));
> > +  SVN_ERR(svn_stream_close(hb->temp_filestream));
> 
> The standard handler already closes the stream for you and if you don't
> disown the file on mapping, this also closes the file.
> 
> > +  svn_pool_destroy(hb->pool);
> 
> And as you clear the pool that contains the file and stream here, closing
> yourself is not necessary.

I realize this, but I closed the stream anyway to make debugging
easier. The pool is only destroyed much later. Do you think this is
bad policy?

-- Ram

      parent reply	other threads:[~2010-07-09 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  8:35 [PATCH] Add svnrdump Ramkumar Ramachandra
2010-07-08  9:28 ` Bert Huijben
2010-07-08  8:17   ` Daniel Shahaf
2010-07-09  0:42     ` Blair Zajac
2010-07-09  8:16       ` Michael J Gruber
2010-07-09 12:40         ` Sverre Rabbelier
2010-07-09 16:51         ` Junio C Hamano
2010-07-09 13:43     ` Ramkumar Ramachandra
2010-07-09 13:42   ` Ramkumar Ramachandra
2010-07-09 14:17     ` Ramkumar Ramachandra
2010-07-09 13:46   ` Ramkumar Ramachandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100709134600.GD12315@debian \
    --to=artagnon@gmail.com \
    --cc=bert@qqmail.nl \
    --cc=dev@subversion.apache.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).