git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Nicolas Pitre <nico@fluxnic.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] test-lib: clean up trash* directories on SIGINT
Date: Mon, 12 Jul 2010 01:16:08 -0500	[thread overview]
Message-ID: <20100712061608.GA6140@burratino> (raw)
In-Reply-To: <AANLkTindliEmS2XhH8B1dUyo-v-CzpLQBqZakOaNnARW@mail.gmail.com>

Hi Ævar,

Ævar Arnfjörð Bjarmason wrote:

> Unless that's due to some unreproducable heisenbug you could get the
> trash directory by running the test with --debug.

So what should I do after noticing a heisenbug?  I guess I can suspend
with ^Z, but I would prefer not to have to train my fingers away from ^C.

> These trash directories are explicitly temporary, and
> should be cleaned up as the shell exists.

When tests learned to remove the trash directory in test_done in
v1.6.1-rc1~336^2~1 (Enable parallel tests, 2008-08-08), that was not
the rationale; it was rather to avoid too many trash directories
piling up.  If a test exits by mistake with ‘exit’ or fails with ‘-i’,
the one or two scratch directories involved are still kept for
debugging.

So you can see why a person would be reluctant to change this for
aesthetic reasons only.

  reply	other threads:[~2010-07-12  6:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11  9:51 [PATCH/RFC] test-lib: clean up trash* directories on SIGINT Ævar Arnfjörð Bjarmason
2010-07-11 11:55 ` Andreas Schwab
2010-07-12  3:32 ` Nicolas Pitre
2010-07-12  5:42   ` Ævar Arnfjörð Bjarmason
2010-07-12  6:16     ` Jonathan Nieder [this message]
2010-07-12  8:16       ` Ævar Arnfjörð Bjarmason
2010-07-12  8:56         ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100712061608.GA6140@burratino \
    --to=jrnieder@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).