From: Jonathan Nieder <jrnieder@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sverre Rabbelier <srabbelier@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] revert: don't print "Finished one cherry-pick." if commit failed
Date: Mon, 12 Jul 2010 11:39:35 -0500 [thread overview]
Message-ID: <20100712163934.GA1869@burratino> (raw)
In-Reply-To: <20100712115455.12251.47449.chriscool@tuxfamily.org>
Christian Couder wrote:
> And, while at it, refactor commit code into a new run_git_commit()
> function.
Probably should be two patches.
> +++ b/builtin/revert.c
> @@ -492,48 +518,17 @@ static int do_pick_commit(void)
> mebuf.buf, help_msg());
> rerere(allow_rerere_auto);
> } else {
> - fprintf(stderr, "Finished one %s.\n", mebuf.buf);
> + if (!no_commit)
> + res = run_git_commit(defmsg);
> + if (!res)
> + fprintf(stderr, "Finished one %s.\n", mebuf.buf);
> }
Ack for this part. Thanks.
next prev parent reply other threads:[~2010-07-12 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 11:54 [PATCH 2/2] revert: don't print "Finished one cherry-pick." if commit failed Christian Couder
2010-07-12 16:39 ` Jonathan Nieder [this message]
2010-07-13 21:06 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712163934.GA1869@burratino \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=artagnon@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).