git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Raja R Harinath <harinath@hurrynot.org>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
	David Barr <david.barr@cordelta.com>
Subject: Re: [PATCH] fast-import: export correctly marks larger than 2^20-1
Date: Tue, 13 Jul 2010 13:31:27 -0500	[thread overview]
Message-ID: <20100713183126.GA2458@burratino> (raw)
In-Reply-To: <1279021908-21291-1-git-send-email-harinath@hurrynot.org>

(+cc David, who I think mentioned wishing for something like this)

Raja R Harinath wrote:

> Subject: fast-import: export correctly marks larger than 2^20-1

Thank you!  That would be a very good thing.

> dump_marks_helper() has a bug when dumping marks larger than 2^20-1,
> i.e., when the sparse array has more than two levels.  The bug was
> that the 'base' counter was being shifted by 20 bits at level 3, and
> then again by 10 bits at level 2, rather than a total shift of 20 bits
> in this argument to the recursive call:

I haven’t read or grokked that code you are changing, so I can’t
comment on the substance of your patch.  In case no one with such
knowledge turns up, could you give a quick summary of what the
existing code does and why?

Barring that, v1.5.0-rc4~14^2~61 (Added option to export the marks
table when fast-import terminates., 2006-08-25) might be a good
starting point for a person looking to understand.

  reply	other threads:[~2010-07-13 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 11:51 [PATCH] fast-import: export correctly marks larger than 2^20-1 Raja R Harinath
2010-07-13 18:31 ` Jonathan Nieder [this message]
2010-07-14  6:48   ` Raja R Harinath
2010-08-10 14:20 ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100713183126.GA2458@burratino \
    --to=jrnieder@gmail.com \
    --cc=david.barr@cordelta.com \
    --cc=git@vger.kernel.org \
    --cc=harinath@hurrynot.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).