git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Bert Huijben <rhuijben@collab.net>
Cc: 'Stefan Sperling' <stsp@elego.de>,
	dev@subversion.apache.org,
	'Daniel Shahaf' <d.s@daniel.shahaf.name>,
	'Will Palmer' <wmpalmer@gmail.com>,
	'David Michael Barr' <david.barr@cordelta.com>,
	'Jonathan Nieder' <jrnieder@gmail.com>,
	'Sverre Rabbelier' <srabbelier@gmail.com>,
	'Git Mailing List' <git@vger.kernel.org>
Subject: Re: [PATCH v2] Add svnrdump
Date: Thu, 15 Jul 2010 14:07:32 +0200	[thread overview]
Message-ID: <20100715120732.GF22574@debian> (raw)
In-Reply-To: <000101cb238a$5b2bfea0$1183fbe0$@collab.net>

Hi Bert,

Bert Huijben writes:
> > >  - I've seen a "Prop-delta: true" line which svnadmin dump does not
> print.
> > 
> > Correct. `svnadmin dump` has a logic for determining when the prop is
> > really a delta (as opposed to a delta against /dev/null). Since
> > there's no harm printing extra Prop-delta headers, I decided not to
> > implement this logic.
> 
> Do you know if this is this something as simple as: 'Is this a new node?' or
> if this is some advanced scheme?

The former actually; although the task looks deceptively simple, it's
a little more involved than that: I'm a little worried about messing
up the node-action-handling logic, as it might break something. Once
we have a large server constantly running validations against my
latest changes, I can change stuff more confidently.

> > gawk '$0 !~ "Prop-delta: true|Text-delta-base-|sha1|Text-copy-source-|^-
> > $" && $0 ~ "^+|^-" { print; }'
> 
> Your mail explains Prop-delta, sha1, but what about these Text-delta-base
> and Text-copy-source lines?

These headers are also not strictly necessary, and I haven't found out
where this information is hidden. I'll dig through the API and find
out where this information and print it later.

-- Ram

  reply	other threads:[~2010-07-15 12:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 14:29 [PATCH v2] Add svnrdump Ramkumar Ramachandra
2010-07-13 20:11 ` Stefan Sperling
2010-07-14 15:32   ` Stefan Sperling
2010-07-14 16:01     ` Ramkumar Ramachandra
2010-07-14 16:48       ` C. Michael Pilato
2010-07-15 10:28         ` Ramkumar Ramachandra
2010-07-14 17:24       ` Stefan Sperling
2010-07-14 17:31         ` C. Michael Pilato
2010-07-14 17:34           ` Stefan Sperling
2010-07-14 17:47           ` Jonathan Nieder
2010-07-14 17:56             ` C. Michael Pilato
2010-07-15 12:01         ` Ramkumar Ramachandra
2010-07-14 19:25       ` Bert Huijben
2010-07-15 12:07         ` Ramkumar Ramachandra [this message]
2010-07-15 19:02   ` Ramkumar Ramachandra
2010-07-15 19:23     ` Stefan Sperling
2010-07-21 11:46       ` Ramkumar Ramachandra
2010-07-21 13:29         ` Daniel Shahaf
2010-07-21 19:03   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100715120732.GF22574@debian \
    --to=artagnon@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=david.barr@cordelta.com \
    --cc=dev@subversion.apache.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=rhuijben@collab.net \
    --cc=srabbelier@gmail.com \
    --cc=stsp@elego.de \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).