From: Christian Couder <chriscool@tuxfamily.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sverre Rabbelier <srabbelier@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 4/4] revert: improve success message by adding abbreviated commit sha1
Date: Sat, 17 Jul 2010 22:17:02 +0200 [thread overview]
Message-ID: <201007172217.02500.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20100715225141.GB7253@burratino>
On Friday 16 July 2010 00:51:41 Jonathan Nieder wrote:
> Christian Couder wrote:
> > Instead of "Finished one cherry-pick." or "Finished one
> > revert.", we now print "Finished cherry-pick commit
> > <abbreviated sha1>."
>
> “Finished cherry-pick of commit f67ab8.” sounds more better to my ear.
>
> Finished cherry-pick of foo.
> Finished cherry-pick of bar.
> Finished cherry-pick of baz.
> etc
>
> is a lot saner than
>
> Finished one cherry-pick.
> Finished one cherry-pick.
> Finisehd one cherry-pick.
> etc
>
> Thanks for making it happen.
Thanks for your review and your patches to improve my patches!
And thanks to Junio for picking up everything!
Best regards,
Christian.
prev parent reply other threads:[~2010-07-17 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 23:28 [PATCH 4/4] revert: improve success message by adding abbreviated commit sha1 Christian Couder
2010-07-15 22:51 ` Jonathan Nieder
2010-07-17 20:17 ` Christian Couder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007172217.02500.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).