From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Petr Baudis <pasky@ucw.cz>
Subject: Re: [PATCHv2 GSOC 09/11] gitweb: Create Gitweb::Util module
Date: Sun, 18 Jul 2010 19:45:45 +0200 [thread overview]
Message-ID: <201007181945.46117.jnareb@gmail.com> (raw)
In-Reply-To: <1279178951-23712-10-git-send-email-pavan.sss1991@gmail.com>
On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote:
> Create Gitweb::Util module in 'gitweb/lib/Gitweb/Util.pm'
> to store the git utility subroutines related to gitweb.
>
> This module include subroutines in various categories
> such as git utility subs invoking git commands, git
> utility subs accessing git repository, mimetype related
> subs and HTML output utility subs.
O.K. so the theme is small helper subroutines, isn't it?
>
> Subroutines moved:
> git_get_head_hash
> git_get_full_hash
> git_get_short_hash
> git_get_hash
> git_get_type
> git_get_hash_by_path
> git_get_path_by_hash
> git_get_last_activity
> git_get_references
> git_get_rev_name_tags
> git_get_heads_list
> git_get_tags_list
> mimetype_guess_file
> mimetype_guess
> blob_mimetype
> blob_contenttype
> guess_file_syntax
> run_highlighter
> fill_from_file_info
> is_deleted
> is_patch_split
Just a question: shouldn't git_get_last_activity subroutine be in
Gitweb::RepoConfig module? Or is Gitweb::RepoConfig only about "static"
properties of a repository?
>
> Update 'gitweb/Makefile' to install Gitweb::Util alongside gitweb.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
> ---
I have not checked the patch, but is should be mainly straightforward
code movement plus some boilerplate.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-07-18 17:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 7:29 [PATCHv2 00/11] Splitting gitweb Pavan Kumar Sunkara
2010-07-15 7:29 ` [PATCHv2 GSOC 01/11] gitweb: fix esc_url Pavan Kumar Sunkara
2010-07-15 13:52 ` Jakub Narebski
2010-07-15 18:57 ` Junio C Hamano
2010-07-15 19:32 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 02/11] gitweb: Prepare for splitting gitweb Pavan Kumar Sunkara
2010-07-15 18:05 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 03/11] gitweb: Create Gitweb::Git module Pavan Kumar Sunkara
2010-07-15 20:13 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 04/11] gitweb: Create Gitweb::Config module Pavan Kumar Sunkara
2010-07-15 21:21 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 05/11] gitweb: Create Gitweb::Request module Pavan Kumar Sunkara
2010-07-16 0:11 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 06/11] gitweb: Create Gitweb::Escape module Pavan Kumar Sunkara
2010-07-16 9:01 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 07/11] gitweb: Create Gitweb::RepoConfig module Pavan Kumar Sunkara
2010-07-16 12:11 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 08/11] gitweb: Create Gitweb::View module Pavan Kumar Sunkara
2010-07-18 15:10 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 09/11] gitweb: Create Gitweb::Util module Pavan Kumar Sunkara
2010-07-18 17:45 ` Jakub Narebski [this message]
2010-07-15 7:29 ` [PATCHv2 GSOC 10/11] gitweb: Create Gitweb::Format module Pavan Kumar Sunkara
2010-07-18 20:16 ` Jakub Narebski
2010-07-15 7:29 ` [PATCHv2 GSOC 11/11] gitweb: Create Gitweb::Parse module Pavan Kumar Sunkara
2010-07-19 14:55 ` Jakub Narebski
2010-08-01 20:44 ` [PATCHv2 00/11] Splitting gitweb Sverre Rabbelier
2010-08-02 15:03 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007181945.46117.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).