From: Christian Couder <chriscool@tuxfamily.org>
To: Peter Baumann <waste.manager@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sverre Rabbelier <srabbelier@gmail.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/7] revert: refactor code to find commit subject in find_commit_subject()
Date: Fri, 23 Jul 2010 11:37:59 +0200 [thread overview]
Message-ID: <201007231138.00360.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20100722165012.GA4938@m62s10.vlinux.de>
On Thursday 22 July 2010 18:50:12 Peter Baumann wrote:
> Wouldn't it be better to merge this with [PATCH 4/7], so we won't create
> find_commit_subject in revert.c and then immediatly move it to commit.c?
Yeah, I could have merged those 2 patches, but except for the first one I
developed them in the order I sent them. So I didn't think much about merging
some as it felt natural to send them as is.
Best regards,
Christian.
next prev parent reply other threads:[~2010-07-23 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 13:18 [PATCH 0/7] find commit subject refactoring Christian Couder
2010-07-22 13:18 ` [PATCH 1/7] revert: fix off by one read when searching the end of a commit subject Christian Couder
2010-07-22 23:00 ` Jonathan Nieder
2010-07-22 13:18 ` [PATCH 2/7] revert: refactor code to find commit subject in find_commit_subject() Christian Couder
2010-07-22 16:50 ` Peter Baumann
2010-07-23 9:37 ` Christian Couder [this message]
2010-07-22 13:18 ` [PATCH 3/7] revert: rename subject related variables in get_message() Christian Couder
2010-07-22 13:18 ` [PATCH 4/7] commit: move find_commit_subject() into commit.{h,c} Christian Couder
2010-07-22 13:18 ` [PATCH 5/7] bisect: use find_commit_subject() instead of custom code Christian Couder
2010-07-22 13:18 ` [PATCH 6/7] merge-recursive: " Christian Couder
2010-07-22 13:18 ` [PATCH 7/7] blame: " Christian Couder
2010-07-22 18:23 ` [PATCH 0/7] find commit subject refactoring Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007231138.00360.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
--cc=waste.manager@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).