git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/6] Makefile: Split out the untested functions target
Date: Sun, 25 Jul 2010 01:02:19 +0200	[thread overview]
Message-ID: <201007250102.20099.trast@student.ethz.ch> (raw)
In-Reply-To: <1280004663-4887-4-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> Change the coverage-report target so that it doesn't generate the
> coverage-untested-functions file by default. I'm adding more targets
> for doing various things with the gcov files, and they shouldn't all
> run by default.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 63f3f84..5e9a6a2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2299,6 +2299,8 @@ coverage-report:
>  	gcov -b -o builtin builtin/*.c
>  	gcov -b -o xdiff xdiff/*.c
>  	gcov -b -o compat compat/*.c
> +
> +coverage-report-untested-functions:
>  	grep '^function.*called 0 ' *.c.gcov \
>  		| sed -e 's/\([^:]*\)\.gcov: *function \([^ ]*\) called.*/\1: \2/' \
>  		| tee coverage-untested-functions

This should depend on coverage-report, and either have its name
changed to coverage-untested-functions or be .PHONY.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2010-07-24 23:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 20:50 [PATCH 0/6] Detailed test coverage reports for Git Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 1/6] gitignore: Ignore files generated by "make coverage" Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports Ævar Arnfjörð Bjarmason
2010-07-24 22:37   ` Thomas Rast
2010-07-24 23:28     ` Ævar Arnfjörð Bjarmason
2010-07-24 23:41       ` Jonathan Nieder
2010-07-26  5:44         ` Junio C Hamano
2010-07-24 20:51 ` [PATCH 3/6] Makefile: Split out the untested functions target Ævar Arnfjörð Bjarmason
2010-07-24 23:02   ` Thomas Rast [this message]
2010-07-24 23:29     ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 4/6] Makefile: Add coverage-report-cover-db target Ævar Arnfjörð Bjarmason
2010-07-24 23:01   ` Thomas Rast
2010-07-24 23:28     ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 5/6] Makefile: Add coverage-report-cover-db-html target Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 6/6] t/README: A new section about test coverage Ævar Arnfjörð Bjarmason
2010-07-24 21:25   ` Jonathan Nieder
2010-07-24 21:29     ` Jonathan Nieder
2010-07-24 23:17     ` Ævar Arnfjörð Bjarmason
2010-07-24 23:32       ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007250102.20099.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).