From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2 1/7] gitignore: Ignore files generated by "make
 coverage"
Date: Sun, 25 Jul 2010 11:37:42 -0500
Message-ID: <20100725163742.GA25658@burratino>
References: <1280068861-17701-1-git-send-email-avarab@gmail.com>
 <1280068861-17701-2-git-send-email-avarab@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@student.ethz.ch>
To: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason <avarab@gmail.com>
X-From: git-owner@vger.kernel.org Sun Jul 25 18:39:15 2010
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@lo.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1Od4EN-0008Ck-FT
	for gcvg-git-2@lo.gmane.org; Sun, 25 Jul 2010 18:39:15 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751435Ab0GYQjJ convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Sun, 25 Jul 2010 12:39:09 -0400
Received: from mail-gy0-f174.google.com ([209.85.160.174]:49589 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751384Ab0GYQjI (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 25 Jul 2010 12:39:08 -0400
Received: by gyg10 with SMTP id 10so615384gyg.19
        for <git@vger.kernel.org>; Sun, 25 Jul 2010 09:39:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:date:from:to:cc:subject
         :message-id:references:mime-version:content-type:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=jkqR3FrXdzRoYO76Ru91H/pwMwkYIIhABAok1HjndIY=;
        b=riHm2WDTxmL1nJaEpqPFUwM+/X4V5+lTF2FEaiP4r3Eb1tgfM7BOPUSCdHdziNUVYE
         77fS4DkGD2WJ/SUnVhHmjyPEUy/ZSDa90USjBmeTBW+xkDB4gIWAcDe24wHRKz5U9uee
         3iANsN38/7jPHYNYlfpUSTIdj14LvHzRWNMm4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        b=jeeZWtJE4pNGDA97g3BEUBts8xaTAIFiu968Bw/FOT1mfe7ZaJuuABPOd+TP52968p
         ZbTC0sxzm1jvvkHzCSUcGoUs/QZCvOgcxG+XDYsjTm2x7A1bZi2HvjlCpqyH58GY04wJ
         hElFXx8/3L4Wr22FYMQMdZhTIzaJyHd9YVljs=
Received: by 10.100.249.19 with SMTP id w19mr6484824anh.121.1280075946357;
        Sun, 25 Jul 2010 09:39:06 -0700 (PDT)
Received: from burratino (c-98-212-3-231.hsd1.il.comcast.net [98.212.3.231])
        by mx.google.com with ESMTPS id c19sm4741992ana.22.2010.07.25.09.39.05
        (version=SSLv3 cipher=RC4-MD5);
        Sun, 25 Jul 2010 09:39:05 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1280068861-17701-2-git-send-email-avarab@gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/151758>

Hi,

=C6var Arnfj=F6r=F0 Bjarmason wrote:

> Change gitignore to ignore the *.gcda, *.gcno and *.gcov files
> generated by GCC and our coverage invocations.

Good idea.  The following is nitpicking of the worst kind; sorry.

It is easier to maintain frequently-changing lists like .gitignore
and the #include lines in source files if new additions go in some
logical place in the middle instead of the end.  There is less
lock contention that way. :)

So maybe:

diff --git i/.gitignore w/.gitignore
index 0e61845..57f79ef 100644
--- i/.gitignore
+++ w/.gitignore
@@ -181,6 +181,10 @@
 *.[aos]
 *.py[co]
 .depend/
+*.gcda
+*.gcno
+*.gcov
+/coverage-untested-functions
 *+
 /config.mak
 /autom4te.cache
@@ -204,7 +208,3 @@
 *.pdb
 /Debug/
 /Release/
-*.gcda
-*.gcno
-*.gcov
-/coverage-untested-functions
--=20