From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2 0/7] Detailed test coverage reports for Git
Date: Sun, 25 Jul 2010 12:20:12 -0500
Message-ID: <20100725172012.GC8604@burratino>
References: <1280068861-17701-1-git-send-email-avarab@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@student.ethz.ch>
To: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason <avarab@gmail.com>
X-From: git-owner@vger.kernel.org Sun Jul 25 19:21:23 2010
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@lo.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1Od4t8-00071q-Qu
	for gcvg-git-2@lo.gmane.org; Sun, 25 Jul 2010 19:21:23 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751999Ab0GYRVR convert rfc822-to-quoted-printable (ORCPT
	<rfc822;gcvg-git-2@m.gmane.org>); Sun, 25 Jul 2010 13:21:17 -0400
Received: from mail-gw0-f46.google.com ([74.125.83.46]:33049 "EHLO
	mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751105Ab0GYRVQ (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 25 Jul 2010 13:21:16 -0400
Received: by gwb20 with SMTP id 20so1176342gwb.19
        for <git@vger.kernel.org>; Sun, 25 Jul 2010 10:21:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:date:from:to:cc:subject
         :message-id:references:mime-version:content-type:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=ADIws64uwWsV6ZVSZBEWfHvfIFhmvzmRRoPj6IK7vl0=;
        b=xqR4Aaq1XR8TyRfrVleI+s+XAfFVRW+6RHyRLVyGe7YIp0unMpIXGr+ib1EjdhGEL0
         KjKgqBHhI0VwuncinrxQ0ur6BMhtDwNg9hnVD3VaIQgCuqkqnMZAhqaRBI4/jEMHghCu
         /xzEV0P4iFyjfjLi84OotKw3cCqIJ/ghEiA0E=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        b=gU8RLLfJVGoW2symDiOyCv4UCrY4fjtTEf8/DZXbCU5vllnSICa02nEFZJZi3+v4fI
         JV/ulmzMgrJODif1ieIbmjo3lXOboKBsWS8ZGkIf+sW3hEZjawOFtoxHxQPXHROHt9a4
         ROr3UTz+EZZANR90J9mjQeOfPYtVbDQi/8QlE=
Received: by 10.151.68.1 with SMTP id v1mr8106341ybk.383.1280078476192;
        Sun, 25 Jul 2010 10:21:16 -0700 (PDT)
Received: from burratino (c-98-212-3-231.hsd1.il.comcast.net [98.212.3.231])
        by mx.google.com with ESMTPS id q21sm2716451ybk.15.2010.07.25.10.21.14
        (version=SSLv3 cipher=RC4-MD5);
        Sun, 25 Jul 2010 10:21:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1280068861-17701-1-git-send-email-avarab@gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/151763>

=C6var Arnfj=F6r=F0 Bjarmason wrote:

> =C6var Arnfj=F6r=F0 Bjarmason (7):
>   gitignore: Ignore files generated by "make coverage"
>   Makefile: Include subdirectories in "make cover" reports
>   Makefile: Split out the untested functions target
>   Makefile: Add coverage-report-cover-db target
>   Makefile: Add coverage-report-cover-db-html target
>   t/README: A new section about test coverage
>   t/README: Add a note about the dangers of coverage chasing

With whatever subset of the changes I have hinted at seems
suitable,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.