From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH v2 0/7] Detailed test coverage reports for Git Date: Sun, 25 Jul 2010 12:48:32 -0500 Message-ID: <20100725174832.GB9146@burratino> References: <1280068861-17701-1-git-send-email-avarab@gmail.com> <20100725172012.GC8604@burratino> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, Junio C Hamano , Thomas Rast To: =?iso-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason X-From: git-owner@vger.kernel.org Sun Jul 25 19:49:40 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Od5KW-0000Vi-GK for gcvg-git-2@lo.gmane.org; Sun, 25 Jul 2010 19:49:40 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439Ab0GYRtg convert rfc822-to-quoted-printable (ORCPT ); Sun, 25 Jul 2010 13:49:36 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:53656 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105Ab0GYRtf (ORCPT ); Sun, 25 Jul 2010 13:49:35 -0400 Received: by iwn7 with SMTP id 7so2070368iwn.19 for ; Sun, 25 Jul 2010 10:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=s+q3FR2KwUyIMTtP0XHCZTS5UsJMbvsQKxKujJr6w2k=; b=D6Uc7w5Zi1jz5l5z3zhIenJIEt8hQw+B/EYviyRP2MYguUMrkybCgrUD6kfknAQDQL DO93gIZTrSqjLxM1WICdsL7qI5sixEd1V6Ud5MjUn8qNyY/2sXH4W+pumj4kfkhNrlsL xm0XyN5i9lvUq7bIPTduu37zlXETKCKhyPdl8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; b=JLFpWdEZbpRYGt4RI78ZhtROd5WVCgOct4wM0faKHuC7gCntlcrFhCs5MoHLwEqxwl 1g3hbSVokEtiGbH5KtE0cJEfxYZSSv/d37RTvlDh1TK84gT8EQbCrOS6xBxQjGBU033G LpuwUjLPK9vGldcBDcGPrzgxSNLF/pcwIMDwo= Received: by 10.231.200.146 with SMTP id ew18mr6560667ibb.117.1280080174895; Sun, 25 Jul 2010 10:49:34 -0700 (PDT) Received: from burratino (c-98-212-3-231.hsd1.il.comcast.net [98.212.3.231]) by mx.google.com with ESMTPS id g31sm2723927ibh.4.2010.07.25.10.49.34 (version=SSLv3 cipher=RC4-MD5); Sun, 25 Jul 2010 10:49:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: =C6var Arnfj=F6r=F0 Bjarmason wrote: > On Sun, Jul 25, 2010 at 17:20, Jonathan Nieder w= rote: >> =C6var Arnfj=F6r=F0 Bjarmason wrote: >>> =C6var Arnfj=F6r=F0 Bjarmason (7): >>> =A0 gitignore: Ignore files generated by "make coverage" >>> =A0 Makefile: Include subdirectories in "make cover" reports >>> =A0 Makefile: Split out the untested functions target >>> =A0 Makefile: Add coverage-report-cover-db target >>> =A0 Makefile: Add coverage-report-cover-db-html target >>> =A0 t/README: A new section about test coverage >>> =A0 t/README: Add a note about the dangers of coverage chasing [...] > All the changes you made look good, I approve of having them squashed > when this is applied. Thanks. I hope not. :) The change to coverage-clean suggested in my reply to patch 4 needs at least a "-r" after the $(RM), since I had not noticed that cover_db is a directory.