git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Lynn.Lin@emc.com
Cc: git@vger.kernel.org
Subject: Patch follow-up conventions (Re: [PATCH] Makefile: don't include git  version file on 'make clean')
Date: Sun, 25 Jul 2010 13:49:51 -0500	[thread overview]
Message-ID: <20100725184951.GA9636@burratino> (raw)
In-Reply-To: <1279943627-11053-1-git-send-email-Lynn.Lin@emc.com>

Hi Lynn,

Lynn Lin wrote:
> -----Original Message-----
> From: Jonathan Nieder [mailto:jrnieder@gmail.com] 
> Sent: 2010年7月24日 19:52
> To: Lin, Lynn
> Subject: Re: [PATCH] Makefile: don't include git version file on 'make clean'
[...]
> Thanks much ,Jonathan.
> It's my first time to try submit patch to git project:)
> 
> Do I need to re-submit patch to add more message in commit message ?

No problem; it is always good to see people noticing things that can
be improved and fixing them. :)

In general the best thing to do (though hard) is to imagine what
would be most convenient at the receiving end and support that.
This means:

 - do not resend a whole patch when a small fixup would be easier;

 - if there has been a long discussion, once a patch is ready
   send a copy with [PATCH v2] in the subject, with a summary
   of the discussion after the "---" line and cc-ing Junio to let
   him know it is ready for application.

Another piece of advice: please convince your mailer setup to present
replies in a more useful form.  That means snipping out any irrelevant
text and somehow visually distinguishing the text you are quoting from
your reply, like I have done with "> " above.

Hope that helps,
Jonathan

      parent reply	other threads:[~2010-07-25 18:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24  3:53 [PATCH] Makefile: don't include git version file on 'make clean' Lynn.Lin
2010-07-24 12:36 ` Ævar Arnfjörð Bjarmason
2010-07-25  8:49   ` Kevin P. Fleming
2010-07-25 11:28     ` lynn.lin
2010-07-25 11:41       ` Ævar Arnfjörð Bjarmason
2010-07-25 11:46         ` lynn.lin
2010-07-25 11:55           ` Ævar Arnfjörð Bjarmason
2010-07-25 12:02             ` lynn.lin
2010-07-25 12:10               ` Ævar Arnfjörð Bjarmason
2010-07-25 12:05             ` Andreas Schwab
2010-07-25 12:15               ` Ævar Arnfjörð Bjarmason
2010-07-25 12:19                 ` lynn.lin
2010-07-25 12:21                   ` lynn.lin
2010-07-25 12:29                     ` lynn.lin
2010-07-25 12:34                       ` Ævar Arnfjörð Bjarmason
2010-07-25 12:37                         ` lynn.lin
2010-07-25 13:08                           ` Ævar Arnfjörð Bjarmason
2010-07-25 13:21                             ` lynn.lin
2010-07-25 18:49 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100725184951.GA9636@burratino \
    --to=jrnieder@gmail.com \
    --cc=Lynn.Lin@emc.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).