From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Rast Subject: Re: [PATCH v3 0/7] Detailed test coverage reports for Git Date: Mon, 26 Jul 2010 09:43:41 +0200 Message-ID: <201007260943.41703.trast@student.ethz.ch> References: <1280087565-24671-1-git-send-email-avarab@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , Junio C Hamano , Jonathan Nieder To: =?iso-8859-1?q?=C6var_Arnfj=F6r=F0_Bjarmason?= X-From: git-owner@vger.kernel.org Mon Jul 26 09:43:47 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OdILi-0005gM-Kk for gcvg-git-2@lo.gmane.org; Mon, 26 Jul 2010 09:43:46 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510Ab0GZHnl convert rfc822-to-quoted-printable (ORCPT ); Mon, 26 Jul 2010 03:43:41 -0400 Received: from gwse.ethz.ch ([129.132.178.238]:17730 "EHLO gwse.ethz.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752832Ab0GZHnl convert rfc822-to-8bit (ORCPT ); Mon, 26 Jul 2010 03:43:41 -0400 Received: from CAS22.d.ethz.ch (172.31.51.112) by gws01.d.ethz.ch (129.132.178.238) with Microsoft SMTP Server (TLS) id 8.2.254.0; Mon, 26 Jul 2010 09:43:40 +0200 Received: from thomas.localnet (129.132.153.233) by CAS22.d.ethz.ch (172.31.51.112) with Microsoft SMTP Server (TLS) id 14.0.702.0; Mon, 26 Jul 2010 09:43:40 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.31.12-0.2-desktop; KDE/4.4.93; x86_64; ; ) In-Reply-To: <1280087565-24671-1-git-send-email-avarab@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: =C6var Arnfj=F6r=F0 Bjarmason wrote: > =C6var Arnfj=F6r=F0 Bjarmason (7): > gitignore: Ignore files generated by "make coverage" > Makefile: Include subdirectories in "make cover" reports > Makefile: Split out the untested functions target > Makefile: Add coverage-report-cover-db target > Makefile: Add coverage-report-cover-db-html target > t/README: A new section about test coverage > t/README: Add a note about the dangers of coverage chasing Thanks a lot for shaping this up! I need the little patch below to accommodate my addiction for a newer compiler than the one standard for my distribution (but that was an issue before, too). It works very well, and the HTML output is quite nice. Acked-by: Thomas Rast -- 8< -- Subject: [PATCH] Makefile: make gcov invocation configurable If you customize CC to use a different version of gcc, most likely you also need to use a different version of gcov. Make it configurable. Signed-off-by: Thomas Rast --- Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index fdfa4fe..81cb5ac 100644 --- a/Makefile +++ b/Makefile @@ -308,6 +308,7 @@ TCL_PATH =3D tclsh TCLTK_PATH =3D wish PTHREAD_LIBS =3D -lpthread PTHREAD_CFLAGS =3D +GCOV =3D gcov =20 export TCL_PATH TCLTK_PATH =20 @@ -2301,7 +2302,7 @@ coverage-build: coverage-clean =20 coverage-report: $(QUIET_GCOV)for dir in $(object_dirs); do \ - gcov $(GCOVFLAGS) --object-directory=3D$$dir $$dir*.c || exit; \ + $(GCOV) $(GCOVFLAGS) --object-directory=3D$$dir $$dir*.c || exit; \ done =20 coverage-untested-functions: coverage-report --=20 1.7.2.289.g93c76