[BUG] git gui blame: Show History Context [still] broken since 29e5573d

[BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Matthieu Moy]

Hi,

I reported this bug a while ago:

http://kerneltrap.org/mailarchive/git/2010/2/22/24038

In short, the "Show history context" item of the context menu of "git
gui blame" is broken since february. Two patches were proposed:

http://thread.gmane.org/gmane.comp.version-control.git/140688
http://thread.gmane.org/gmane.comp.version-control.git/140288

But I've just noticed that none of theme were applied.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Pat Thoyts]

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

>Hi,
>
>I reported this bug a while ago:
>
>http://kerneltrap.org/mailarchive/git/2010/2/22/24038
>
>In short, the "Show history context" item of the context menu of "git
>gui blame" is broken since february. Two patches were proposed:
>
>http://thread.gmane.org/gmane.comp.version-control.git/140688
>http://thread.gmane.org/gmane.comp.version-control.git/140288
>
>But I've just noticed that none of theme were applied.
>

Checking this it seems you are correct. This has been fixed for
msysGit with the above patch included there but is missing from
git-gui itself and hence missing from core git.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Junio C Hamano]

Pat Thoyts <patthoyts@users.sourceforge.net> writes:

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>>Hi,
>>
>>I reported this bug a while ago:
>>
>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038
>>
>>In short, the "Show history context" item of the context menu of "git
>>gui blame" is broken since february. Two patches were proposed:
>>
>>http://thread.gmane.org/gmane.comp.version-control.git/140688
>>http://thread.gmane.org/gmane.comp.version-control.git/140288
>>
>>But I've just noticed that none of theme were applied.
>
> Checking this it seems you are correct. This has been fixed for
> msysGit with the above patch included there but is missing from
> git-gui itself and hence missing from core git.

Can we resolve this before 1.7.2 final?

Shawn, I see 9c898a1 (git-gui: check whether systems nice command works or
disable it, 2010-02-07) on your 'maint' that is not in mine (and a merge
of that commit on your 'master'), but neither of these.

Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Matthieu Moy]

Junio C Hamano <gitster@pobox.com> writes:

> Pat Thoyts <patthoyts@users.sourceforge.net> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>>Hi,
>>>
>>>I reported this bug a while ago:
>>>
>>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038
>>>
>>>In short, the "Show history context" item of the context menu of "git
>>>gui blame" is broken since february. Two patches were proposed:
>>>
>>>http://thread.gmane.org/gmane.comp.version-control.git/140688
>>>http://thread.gmane.org/gmane.comp.version-control.git/140288
>>>
>>>But I've just noticed that none of theme were applied.
>>
>> Checking this it seems you are correct. This has been fixed for
>> msysGit with the above patch included there but is missing from
>> git-gui itself and hence missing from core git.
>
> Can we resolve this before 1.7.2 final?

Too late for the 1.7.2, but can we finally get one of these patches
applied? They're both very short and straightforward, and fix an
important feature of git-gui which is basically broken as of now.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Jonathan Nieder]

Matthieu Moy wrote:

> Too late for the 1.7.2, but can we finally get one of these patches
> applied? They're both very short and straightforward, and fix an
> important feature of git-gui which is basically broken as of now.

Maybe some interested person should maintain a temporary fork of
git-gui that could be merged in the meantime.  That is what people
seem to usually do with submodules in analogous situations.

Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

[Pat Thoyts]

Jonathan Nieder <jrnieder@gmail.com> writes:

>Matthieu Moy wrote:
>
>> Too late for the 1.7.2, but can we finally get one of these patches
>> applied? They're both very short and straightforward, and fix an
>> important feature of git-gui which is basically broken as of now.
>
>Maybe some interested person should maintain a temporary fork of
>git-gui that could be merged in the meantime.  That is what people
>seem to usually do with submodules in analogous situations.

I pushed git-gui + my patches to git://git.patthoyts.tk/git-gui
(http://www.patthoyts.tk/gitweb.cgi?p=git-gui;a=summary)
so if someone wants to pull from that it is Shawn's repository plus 3.

Alternatively the git-gui patches could be pulled from msysGit which
has a few in addition to these three.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

git gui tree (Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d)

[Jonathan Nieder]

Pat Thoyts wrote:

> I pushed git-gui + my patches to git://git.patthoyts.tk/git-gui
> (http://www.patthoyts.tk/gitweb.cgi?p=git-gui;a=summary)
> so if someone wants to pull from that it is Shawn's repository plus 3.

Quick thoughts:

Were those patches reviewed?  I assume so, but I do not see a
Reviewed-by or anything so I do not know who to blame if they
go awry.

Here[1] is another candidate patch, though it has not received
much attention, unfortunately.

Thanks,
Jonathan

[1] http://thread.gmane.org/gmane.linux.debian.devel.bugs.general/723900/focus=150231