From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Greg Brockman" <gdb@mit.edu>, "Ævar Arnfjörð" <avarab@gmail.com>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCHv3] Updated patch series for providing mechanism to list available repositories
Date: Tue, 27 Jul 2010 12:41:05 -0500 [thread overview]
Message-ID: <20100727174105.GA5578@burratino> (raw)
In-Reply-To: <201007270916.59210.j.sixt@viscovery.net>
Johannes Sixt wrote:
> Windows does have execv. The patch is OK in this regard.
Thanks, that’s a comfort. Sorry to spread misinformation.
---
diff --git a/compat/mingw.c b/compat/mingw.c
index 9a8e336..9212a12 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -854,6 +854,11 @@ static void mingw_execve(const char *cmd, char *const *argv, char *const *env)
}
}
+void mingw_execv(const char *cmd, char *const *argv)
+{
+ mingw_execve(cmd, argv, environ);
+}
+
void mingw_execvp(const char *cmd, char *const *argv)
{
char **path = get_path_split();
diff --git a/compat/mingw.h b/compat/mingw.h
index 3b2477b..d81b2f3 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -237,6 +237,9 @@ pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,
void mingw_execvp(const char *cmd, char *const *argv);
#define execvp mingw_execvp
+void mingw_execv(const char *cmd, char *const *argv);
+#define execv mingw_execv
+
static inline unsigned int git_ntohl(unsigned int x)
{ return (unsigned int)ntohl(x); }
#define ntohl git_ntohl
--
next prev parent reply other threads:[~2010-07-27 17:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 15:15 [PATCHv3] Updated patch series for providing mechanism to list available repositories Greg Brockman
2010-07-21 15:15 ` [PATCH 1/3] Allow creation of arbitrary git-shell commands Greg Brockman
2010-07-21 15:15 ` [PATCH 2/3] Add interactive mode to git-shell for user-friendliness Greg Brockman
2010-07-21 15:15 ` [PATCH 3/3] Add sample commands for git-shell Greg Brockman
2010-07-26 22:32 ` [PATCHv3] Updated patch series for providing mechanism to list available repositories Greg Brockman
2010-07-26 22:54 ` Ævar Arnfjörð Bjarmason
2010-07-26 23:18 ` Greg Brockman
2010-07-27 9:02 ` Jakub Narebski
2010-07-26 23:28 ` Jonathan Nieder
2010-07-27 0:20 ` Greg Brockman
2010-07-27 0:50 ` Jonathan Nieder
2010-07-27 7:16 ` Johannes Sixt
2010-07-27 17:41 ` Jonathan Nieder [this message]
2010-07-27 22:43 ` Greg Brockman
2010-07-28 0:33 ` Jonathan Nieder
2010-07-28 6:15 ` Greg Brockman
2010-07-28 6:42 ` Jonathan Nieder
2010-07-28 7:06 ` Greg Brockman
2010-07-28 23:14 ` Anders Kaseorg
2010-07-28 23:52 ` Jonathan Nieder
2010-07-29 0:21 ` Greg Brockman
2010-07-29 0:33 ` Jonathan Nieder
2010-07-28 1:10 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727174105.GA5578@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=gdb@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).