From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Eli Barzilay <eli@barzilay.org>,
git@vger.kernel.org, Will Palmer <wmpalmer@gmail.com>
Subject: [PATCH 0/3] archive: abbreviate substituted commit ids again
Date: Tue, 27 Jul 2010 13:29:42 -0500 [thread overview]
Message-ID: <20100727182942.GB5578@burratino> (raw)
In-Reply-To: <7vzkxc7rpn.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> isn't
> this one in builtin/commit.c also a confusing no-op?
I see. When setup_revisions is called (which initializes diffopt),
rev.abbrev still equals DEFAULT_ABBREV.
I missed v1.7.1.1~17^2 (commit::print_summary(): don't use
format_commit_message(), 2010-06-12) and did not notice that the bug had
gone away. Sorry for the confusion.
Here’s a rerolled series.
Jonathan Nieder (3):
archive: abbreviate substituted commit ids again
checkout, commit: remove confusing assignments to rev.abbrev
examples/commit: use --abbrev for commit summary
archive.c | 1 +
builtin/checkout.c | 1 -
builtin/commit.c | 1 -
contrib/examples/git-commit.sh | 2 +-
t/t5001-archive-attr.sh | 2 +-
5 files changed, 3 insertions(+), 4 deletions(-)
--
1.7.2.21.g04ff
next prev parent reply other threads:[~2010-07-27 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 9:08 Possible bug with `export-subst' attribute Eli Barzilay
2010-07-25 13:09 ` Ilari Liusvaara
2010-07-25 22:15 ` Jonathan Nieder
2010-07-25 22:41 ` Eli Barzilay
2010-07-26 6:01 ` Junio C Hamano
2010-07-26 19:04 ` Jonathan Nieder
2010-07-27 17:35 ` Junio C Hamano
2010-07-27 18:29 ` Jonathan Nieder [this message]
2010-07-27 18:32 ` [PATCH 1/3] archive: abbreviate substituted commit ids again Jonathan Nieder
2010-07-27 18:37 ` [PATCH 2/3] checkout, commit: remove confusing assignments to rev.abbrev Jonathan Nieder
2010-07-27 20:18 ` Will Palmer
2010-07-27 21:09 ` Jonathan Nieder
2010-07-28 10:01 ` Will Palmer
2010-07-28 17:23 ` Junio C Hamano
2010-07-27 18:44 ` [PATCH 3/3] examples/commit: use --abbrev for commit summary Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727182942.GB5578@burratino \
--to=jrnieder@gmail.com \
--cc=eli@barzilay.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox