From: Avery Pennarun <apenwarr@gmail.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: skillzero@gmail.com, "Marc Branchaud" <marcnarc@xiplink.com>,
"Jens Lehmann" <Jens.Lehmann@web.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Bryan Larsen" <bryan.larsen@gmail.com>,
git <git@vger.kernel.org>, "Junio C Hamano" <gitster@pobox.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: Avery Pennarun's git-subtree?
Date: Tue, 27 Jul 2010 14:36:58 -0400 [thread overview]
Message-ID: <20100727183658.GB25124@worldvisions.ca> (raw)
In-Reply-To: <201007261056.58985.jnareb@gmail.com>
On Mon, Jul 26, 2010 at 10:56:58AM +0200, Jakub Narebski wrote:
> On Sat, Jul 24, 2010, skillzero@gmail.com napisał:
> > git-submodule might be technically possible in this situation, but
> > having to commit and push each submodule and then commit and push the
> > super module makes it slightly worse than just dealing with the
> > space/download/performance issues of one huge repository.
>
> But this is just a matter for improving UI for dealing with submodules,
> isn't it. For example having "git commit --recursive" would help
> with 'having to commit each submodule', though how you would write commit
> messages then: perhaps supermodule commit message could be by default
> composed out of submodules commits (if any). "git push --recursive"
> (or some support for push in "git remote") would help with 'having to
> push each submodule'.
For "recursive" commit, for my own workflow, I would rather have it work
like this: from the toplevel, I can 'git commit' any set of files, as long
as they all fall inside a particular submodule. That is, if I do
git commit mod1/*.c mod2/*.c
it should reject it (with a helpful message), because the commit would cross
submodule boundaries. But if I do
git commit mod1/*.c
I think it should create a new commit in mod1, leave my superproject
pointing at that new commit, and stop (ie. without the superproject having
committed the new commit pointer).
Why? Because my normal workflow is:
- make a bunch of superproject/submodule changes until they work.
- commit the submodule changes with a submodule-relevant message
- commit the superproject change with a supermodule-relevant message
I wouldn't want to share commit messages between the two, so actually having
a single commit process be "recursive" would not do me any good.
However, pushing is a separate issue entirely. Having push be recursive
would be easy, but it doesn't solve the *real* problem with pushing: git
doesn't know what branch to push to in the submodule, and the submodule most
likely isn't pointing at a pushable repo at all, even if the supermodule is.
This is why I keep coming back to the idea that I really want to push all
the submodule objects into the superproject's repo.
Have fun,
Avery
next prev parent reply other threads:[~2010-07-27 18:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 17:15 Avery Pennarun's git-subtree? Bryan Larsen
2010-07-21 19:43 ` Ævar Arnfjörð Bjarmason
2010-07-21 19:56 ` Avery Pennarun
2010-07-21 20:36 ` Ævar Arnfjörð Bjarmason
2010-07-21 21:09 ` Avery Pennarun
2010-07-21 21:20 ` Avery Pennarun
2010-07-21 22:46 ` Jens Lehmann
2010-07-22 1:09 ` Avery Pennarun
[not found] ` <m31vavn8la.fsf@localhost.localdomain>
2010-07-22 18:23 ` Bryan Larsen
2010-07-24 22:36 ` Jakub Narebski
2010-07-22 19:41 ` Avery Pennarun
2010-07-22 19:56 ` Jonathan Nieder
2010-07-22 20:06 ` Avery Pennarun
2010-07-22 20:17 ` Ævar Arnfjörð Bjarmason
2010-07-22 21:33 ` Avery Pennarun
2010-07-23 15:10 ` Jens Lehmann
2010-07-26 17:34 ` Eugene Sajine
2010-07-22 20:43 ` Elijah Newren
2010-07-22 21:32 ` Avery Pennarun
2010-07-23 8:31 ` Chris Webb
2010-07-23 8:40 ` Avery Pennarun
2010-07-23 15:11 ` Jens Lehmann
2010-07-23 22:33 ` Avery Pennarun
2010-07-23 15:13 ` Jens Lehmann
2010-07-23 15:10 ` Jens Lehmann
2010-07-23 16:05 ` Bryan Larsen
2010-07-23 17:11 ` Jens Lehmann
2010-07-23 19:01 ` Bryan Larsen
2010-07-23 22:32 ` Avery Pennarun
2010-07-25 19:57 ` Jens Lehmann
2010-07-27 18:40 ` Avery Pennarun
2010-07-27 21:14 ` Jens Lehmann
2010-07-23 15:19 ` Marc Branchaud
2010-07-23 22:50 ` Avery Pennarun
2010-07-24 0:58 ` skillzero
2010-07-24 1:20 ` Avery Pennarun
2010-07-24 19:40 ` skillzero
2010-07-25 1:47 ` Nguyen Thai Ngoc Duy
2010-07-28 22:27 ` Jakub Narebski
2010-07-26 13:13 ` Jakub Narebski
2010-07-26 16:37 ` Marc Branchaud
2010-07-26 16:41 ` Linus Torvalds
2010-07-26 17:36 ` Bryan Larsen
2010-07-26 17:48 ` Linus Torvalds
2010-07-27 18:28 ` Avery Pennarun
2010-07-27 20:25 ` Junio C Hamano
2010-07-27 20:57 ` Avery Pennarun
2010-07-27 21:14 ` Junio C Hamano
2010-07-27 21:32 ` Jens Lehmann
2010-07-26 8:56 ` Jakub Narebski
2010-07-27 18:36 ` Avery Pennarun [this message]
2010-07-28 13:36 ` Marc Branchaud
2010-07-28 18:32 ` Jakub Narebski
2010-07-24 20:07 ` Sverre Rabbelier
2010-07-26 8:51 ` Jakub Narebski
2010-07-27 19:15 ` Avery Pennarun
2010-07-26 15:15 ` Marc Branchaud
2010-07-21 23:46 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727183658.GB25124@worldvisions.ca \
--to=apenwarr@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=avarab@gmail.com \
--cc=bryan.larsen@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=marcnarc@xiplink.com \
--cc=skillzero@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).