From: Jakub Narebski <jnareb@gmail.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options.
Date: Thu, 29 Jul 2010 11:16:42 +0200 [thread overview]
Message-ID: <201007291116.44859.jnareb@gmail.com> (raw)
In-Reply-To: <20100728130610.GG6895@madism.org>
On Wed, 28 Jul 2010, Pierre Habouzit wrote:
> you cannot take the address of a bit portably in C, so you can't let
> parseopt set/clear bits through bitfields (as in unsigned field : 1 in a
> struct in C I mean).
>
> So to use parseopt OPTION_BIT feature, you have to convert them to C
> flags as in "unsigned flags" and explicit masks defines/enums.
>
> IOW:
>
> struct foo {
> unsigned bar : 1,
> ...
> baz : 1;
> };
>
> Must be converted into:
>
> struct foo {
> #define FOO_FLAG_BAR (1U << 1)
> ...
> #define FOO_FLAG_BAZ (1U << 18)
> unsigned flags;
> }
>
> so that you can use parseopt. that's what I meant.
>
>
> This was done for the rev-list parsing stuff e.g.
e.g. what?
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-07-29 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 18:14 [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options Matthieu Moy
2010-07-26 18:14 ` [RFC PATCH 1/2] Allow "git log --grep foo" as synonym for "git log --grep=foo" Matthieu Moy
2010-07-27 6:43 ` Sverre Rabbelier
2010-07-27 8:40 ` Miles Bader
2010-07-27 10:24 ` Jakub Narebski
2010-07-27 8:45 ` Matthieu Moy
2010-07-27 10:18 ` Ævar Arnfjörð Bjarmason
2010-07-27 11:56 ` Matthieu Moy
2010-07-27 12:21 ` Ævar Arnfjörð Bjarmason
2010-07-27 13:26 ` Matthieu Moy
2010-07-27 13:46 ` Ævar Arnfjörð Bjarmason
2010-07-26 18:14 ` [RFC PATCH 2/2] Allow "git log -S string" as synonym for "git log -Sstring" Matthieu Moy
2010-07-27 6:42 ` Sverre Rabbelier
2010-07-26 19:31 ` [RFC PATCH 0/2] Allow detached forms (--option arg) for git log options Jonathan Nieder
2010-07-27 14:46 ` Pierre Habouzit
2010-07-27 15:10 ` Jakub Narebski
2010-07-28 13:06 ` Pierre Habouzit
2010-07-29 9:16 ` Jakub Narebski [this message]
2010-07-29 18:33 ` Pierre Habouzit
2010-08-01 5:24 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007291116.44859.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).