From: Jonathan Nieder <jrnieder@gmail.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 4/5] log: parse detached options like git log --grep foo
Date: Thu, 29 Jul 2010 17:25:16 -0500 [thread overview]
Message-ID: <20100729222436.GA1824@burratino> (raw)
In-Reply-To: <1280391629-30017-5-git-send-email-Matthieu.Moy@imag.fr>
Hi,
Glance over this again:
> +++ b/revision.c
> @@ -1382,12 +1400,12 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
> revs->grep_filter.fixed = 1;
> } else if (!strcmp(arg, "--all-match")) {
> revs->grep_filter.all_match = 1;
> - } else if (!prefixcmp(arg, "--encoding=")) {
> - arg += 11;
> + } else if ((argcount = diff_long_opt("encoding", argv, &optarg))) {
> if (strcmp(arg, "none"))
> - git_log_output_encoding = xstrdup(arg);
> + git_log_output_encoding = xstrdup(optarg);
I think arg should be optarg in the string comparison, too. Sorry I
didn’t notice last time.
I wonder why t3900 and t8005 do not catch this.
> else
> git_log_output_encoding = "";
Curious,
Jonathan
next prev parent reply other threads:[~2010-07-29 22:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 8:20 [PATCH 0/5 v3] log and diff: accept detached forms (--option value) Matthieu Moy
2010-07-29 8:20 ` [PATCH 1/5] diff: parse detached options like -S foo Matthieu Moy
2010-07-29 8:20 ` [PATCH 2/5] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-29 8:20 ` [PATCH 3/5] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-07-29 8:20 ` [PATCH 4/5] log: parse detached options like git log --grep foo Matthieu Moy
2010-07-29 22:25 ` Jonathan Nieder [this message]
2010-07-30 8:27 ` Matthieu Moy
2010-07-30 8:31 ` [PATCH 1/5 v4] diff: parse detached options like -S foo Matthieu Moy
2010-08-02 16:46 ` Junio C Hamano
2010-08-02 19:43 ` Matthieu Moy
2010-08-02 19:47 ` Jonathan Nieder
2010-07-30 8:31 ` [PATCH 2/5 v4] diff: split off a function for --stat-* option parsing Matthieu Moy
2010-07-30 8:31 ` [PATCH 3/5 v4] diff: parse detached options --stat-width n, --stat-name-width n Matthieu Moy
2010-08-02 16:56 ` Junio C Hamano
2010-08-02 18:47 ` Matthieu Moy
2010-07-30 8:31 ` [PATCH 4/5 v4] log: parse detached options like git log --grep foo Matthieu Moy
2010-08-02 17:03 ` Junio C Hamano
2010-08-02 18:55 ` Matthieu Moy
2010-08-02 21:28 ` Junio C Hamano
2010-08-03 6:33 ` Matthieu Moy
2010-08-03 17:16 ` Junio C Hamano
2010-08-03 19:52 ` Matthieu Moy
2010-08-04 2:41 ` Miles Bader
2010-07-30 8:31 ` [PATCH 5/5 v4] log: parse detached option for --glob Matthieu Moy
2010-07-29 8:20 ` [PATCH 5/5] " Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729222436.GA1824@burratino \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).