From: Thomas Rast <trast@student.ethz.ch>
To: Joshua Jensen <jjensen@workspacewhiz.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Giuseppe Scrivano <gscrivano@gnu.org>,
"git@vger.kernel.org" <git@vger.kernel.org>,
<msysgit@googlegroups.com>
Subject: Re: [msysGit] git rev-parse broken on Git for Windows
Date: Fri, 30 Jul 2010 11:02:15 +0200 [thread overview]
Message-ID: <201007301102.15274.trast@student.ethz.ch> (raw)
In-Reply-To: <alpine.DEB.1.00.1007301022310.2983@bonsai2>
Johannes Schindelin wrote:
> Hi,
>
> On Thu, 29 Jul 2010, Joshua Jensen wrote:
>
> > 9c7304e3e39ed397b3cc6566573333e2698a52b4 (print the usage string on stdout
> > instead of stderr) and then 47e9cd28f8a404a0d6293935252ddca5fc243931
> > (parseopt: wrap rev-parse --parseopt usage for eval consumption) break the
> > following line from the manual and 'git subtree' on msysGit:
> >
> > eval $(echo "$OPTS_SPEC" | git rev-parse --parseopt -- "$@" || echo exit $?)
>
> Both commits are from Junio's 'next' branch. I Cc:ed the authors of both
> commits.
Can you elaborate on "break"?
Because as you can see in git-sh-setup.sh, the "official" user of
parseopt does
eval "$(
echo "$OPTIONS_SPEC" |
git rev-parse --parseopt $parseopt_extra -- "$@" ||
echo exit $?
)"
So AFAICS they only differ in the quoting. And the latter works.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-07-30 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 5:25 git rev-parse broken on Git for Windows Joshua Jensen
2010-07-30 8:26 ` [msysGit] " Johannes Schindelin
2010-07-30 9:02 ` Thomas Rast [this message]
2010-07-30 14:26 ` Joshua Jensen
2010-07-30 14:43 ` Thomas Rast
2010-07-30 15:01 ` [PATCH] Documentation/rev-parse: quoting is required with --parseopt Thomas Rast
2010-07-30 16:44 ` [msysGit] git rev-parse broken on Git for Windows Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007301102.15274.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gscrivano@gnu.org \
--cc=jjensen@workspacewhiz.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).