From: Jonathan Nieder <jrnieder@gmail.com>
To: Matt Wozniski <godlygeek@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: "clean" filter breaks git-svn
Date: Fri, 30 Jul 2010 15:31:11 -0500 [thread overview]
Message-ID: <20100730203111.GD2448@burratino> (raw)
In-Reply-To: <AANLkTikp6PgHyj2ujbuD52884ny88hMyxR1CpsbNAVCJ@mail.gmail.com>
Hi Matt,
Matt Wozniski wrote:
> When trying to fetch
> commits A and B from the SVN repos, it will fetch A, and then clean(A)
> is committed to my repository. Then when it tries to fetch B, it is
> horribly confused - it complains of a checksum mismatch, since the
> md5sums of the files in A in the SVN repos don't match up with the
> md5sums of the files in the clean(A) commit in git land.
Interesting. Yeah, that sounds like a bug.
I am not convinced cleaning fetched files is the right thing to do in
the first place (why not just trust the SVN repo?), but I assume
people with workflows involving such filters could make a better call.
> Is this a
> known problem?
There is no test for it in git.git, so in that sense no.
> Could git-svn be made to accept the
> md5sum of *either* A or clean(A) instead?
I don’t think that would be right. It’s not just the md5sums not
matching that is the problem; it is that in these situations git-svn
and the SVN server do not agree about the file’s current content.
Once the code makes the semantics clear, I assume it should Just
Work™.
Good luck,
Jonathan
next prev parent reply other threads:[~2010-07-30 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 3:55 "clean" filter breaks git-svn Matt Wozniski
2010-07-30 20:31 ` Jonathan Nieder [this message]
2010-07-30 21:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730203111.GD2448@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=godlygeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).