git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: git@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: gitweb not friendly to firefox revived
Date: Sun, 1 Aug 2010 21:51:38 +0200	[thread overview]
Message-ID: <20100801195138.GA1980@pengutronix.de> (raw)

Hello,

gitweb (at least) doesn't quote author names enough.

Firefox barfs for me at looking at

	http://git.pengutronix.de/?p=ukl/linux-2.6.git;a=shortlog;h=v2.6.16.10

with an error:

	XML Parsing Error: not well-formed Location:
http://git.pengutronix.de/?p=ukl/linux-2.6.git;a=shortlog;h=v2.6.16.10
Line Number 112, Column 81:
<td class="author"><a title="Search for commits authored by YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" class="list" href="/?p=ukl/linux-2.6.git;a=search;h=v2.6.16.10;s=YOSHIFUJI+Hideaki+/+%1B%24B5HF%231QL@%1B(B;st=author"><span title="YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B">YOSHIFUJI Hideaki...  </span></a></td><td><a class="list subject" title="[PATCH] IPV6: XFRM: Fix decoding session with preceding extension header(s)." href="/?p=ukl/linux-2.6.git;a=commit;h=fa39df2ff7f6102f1f37d3cf1f68243534d56253">[PATCH] IPV6: XFRM: Fix decoding session with preceding... </a></td>
--------------------------------------------------------------------------------^

This is with git 1.7.1 and Iceweasel (aka. Firefox) 3.5.10.

Making

	title=>"Search for commits $performed by $author"

in line 1694 of Debian's /usr/lib/cgi-bin/gitweb.cgi from the git 1.7.1
package read

	title=>esc_html("Search for commits $performed by $author")

this problem goes away.  (Still my browser barfs when clicking at the name.)

I'm not sure if this is the right way to fix this and I'm too tired now
to do a complete patch, so I let this for someone else.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

             reply	other threads:[~2010-08-01 19:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-01 19:51 Uwe Kleine-König [this message]
2010-08-01 20:15 ` gitweb not friendly to firefox revived Ævar Arnfjörð Bjarmason
2010-08-02  5:31   ` Uwe Kleine-König
2010-08-01 20:26 ` Jakub Narebski
2010-08-03 21:07   ` Uwe Kleine-König
2010-08-03 21:50     ` Jakub Narebski
2010-08-12  9:23       ` Uwe Kleine-König
2010-08-14 10:33       ` Stephen Boyd
2010-08-14 10:48         ` Ævar Arnfjörð Bjarmason
2010-08-14 12:33           ` Jakub Narebski
2010-09-07  8:22             ` Uwe Kleine-König
2010-08-14 12:29         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100801195138.GA1980@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=git@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).