From: Jared Hance <jaredhance@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] rebase -i: add exec command to launch a shell command
Date: Mon, 2 Aug 2010 08:30:01 -0400 [thread overview]
Message-ID: <20100802123001.GA3500@localhost.localdomain> (raw)
In-Reply-To: <1280743433-27803-1-git-send-email-Matthieu.Moy@imag.fr>
On Mon, Aug 02, 2010 at 12:03:53PM +0200, Matthieu Moy wrote:
> The shell command is ran (in the directory where the rebase was started
> by the user)
I disagree with how intuitive this behavior is. "rebase" is a
repository level command - It modifies the objects in the repository.
As a side effect, the working tree attached to a (non-bare) repository
is changed, even outside of where the rebase was ran.
Since the rebase affects the entire repository, I think it makes sense
for the commands to be run out of the repository root.
Perhaps a command-line option for toggling this behavior would be a
good compromise.
next prev parent reply other threads:[~2010-08-02 12:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 13:29 [RFC/PATCH] rebase -i: add run command to launch a shell command Matthieu Moy
2010-07-28 14:12 ` Santi Béjar
2010-07-28 14:26 ` Matthieu Moy
2010-07-30 10:04 ` Matthieu Moy
2010-07-30 14:51 ` Marc Branchaud
2010-07-30 15:24 ` Matthieu Moy
2010-07-30 18:26 ` Neal Kreitzinger
2010-07-31 13:27 ` Matthieu Moy
2010-07-31 13:56 ` Ævar Arnfjörð Bjarmason
2010-07-31 14:25 ` Miles Bader
2010-08-02 10:02 ` Matthieu Moy
2010-08-02 10:03 ` [PATCH] rebase -i: add exec " Matthieu Moy
2010-08-02 12:30 ` Jared Hance [this message]
2010-08-02 15:51 ` Ævar Arnfjörð Bjarmason
2010-08-06 21:07 ` Johannes Sixt
2010-08-07 8:48 ` Matthieu Moy
2010-08-07 8:56 ` [PATCH 1/2 (new version)] " Matthieu Moy
2010-08-07 8:56 ` [PATCH 2/2] test-lib: user-friendly alternatives to test [!] [-d|-f] Matthieu Moy
2010-08-02 15:04 ` [RFC/PATCH] rebase -i: add run command to launch a shell command Paolo Bonzini
2010-08-02 21:15 ` Junio C Hamano
2010-08-03 6:37 ` Matthieu Moy
2010-08-03 8:47 ` Kris Shannon
2010-08-03 9:16 ` Matthieu Moy
2010-07-31 15:28 ` Paolo Bonzini
2010-07-31 15:52 ` Ævar Arnfjörð Bjarmason
2010-07-31 18:54 ` Jared Hance
2010-07-31 14:40 ` Jared Hance
-- strict thread matches above, loose matches on Subject: below --
2010-08-05 13:00 [PATCH] rebase -i: add exec " Matthieu Moy
2010-08-05 13:31 ` Ævar Arnfjörð Bjarmason
2010-08-05 16:47 ` Matthieu Moy
2010-08-05 18:24 ` Erik Faye-Lund
2010-08-05 18:37 ` Jacob Helwig
2010-08-05 20:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802123001.GA3500@localhost.localdomain \
--to=jaredhance@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).