git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
	"Joel C. Salomon" <joelcsalomon@gmail.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: Back-dating commits--way back--for constitution.git
Date: Tue, 3 Aug 2010 15:19:09 +0200	[thread overview]
Message-ID: <201008031519.11012.jnareb@gmail.com> (raw)
In-Reply-To: <20100803124831.GB11608@coredump.intra.peff.net>

On Tue, 3 Aug 2010, Jeff King wrote:
> On Tue, Aug 03, 2010 at 12:02:52PM +0200, Jakub Narebski wrote:
> 
> > > Hmm, sizeof(time_t) == 8 for my x86_64 Fedora, but committing ancient
> > > times fails.
> > 
> > That's because git *porcelain* either does not use time_t consistently,
> > or has some sanity checks that are good heuristic for ordinary use (like
> > e.g. commit time not too far in past where git didn't even exists),
> > or both.
> > 
> > It is not a problem on lowest level, i.e. repository format and plumbing.
> > I was able to create a commit that had author time before Unix epoch 
> > using plumbing:
> 
> I am not sure there isn't some unportability at the lowest level. We
> freely interchange between time_t and unsigned long in the low-level
> date code. It probably happens to work because casting the bits back and
> forth between signed and unsigned types generally works, as long as you
> end up with the type that you want. But it isn't necessarily portable,
> and there can be subtle bugs. See, for example, my recent 9ba0f033.

Well, at least there is not a problem at lowest of low, i.e. repository
format level, thanks to the use of textual representation for epoch.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2010-08-03 13:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02 18:32 Back-dating commits--way back--for constitution.git Joel C. Salomon
2010-08-02 18:34 ` Shawn O. Pearce
2010-08-02 18:41   ` Joel C. Salomon
2010-08-02 21:25 ` Ævar Arnfjörð Bjarmason
2010-08-04 16:38   ` Joel C. Salomon
2010-08-04 19:07     ` Ævar Arnfjörð Bjarmason
2010-08-05 21:37     ` Joel C. Salomon
2010-08-05 21:58       ` Ævar Arnfjörð Bjarmason
2010-08-05 22:10         ` Sverre Rabbelier
2010-08-06  8:18           ` Jakub Narebski
2010-08-06 14:01             ` Michael Witten
2010-08-06 15:08             ` Sverre Rabbelier
2010-08-06 15:18         ` Joel C. Salomon
2010-08-06 15:19           ` Ævar Arnfjörð Bjarmason
2010-08-06 15:29             ` Joel C. Salomon
2010-08-06 16:00             ` Brandon Casey
2010-08-06 16:50               ` Ævar Arnfjörð Bjarmason
2010-08-06 16:44           ` Brandon Casey
2010-08-08  3:46             ` Joel C. Salomon
2010-08-08  4:11               ` Joshua Juran
2010-08-02 21:48 ` Jakub Narebski
2010-08-02 22:47   ` Junio C Hamano
2010-08-03  7:39     ` Jakub Narebski
2010-08-03  8:00       ` Jakub Narebski
2010-08-03  8:55   ` Michael J Gruber
2010-08-03  9:32     ` Joshua Juran
2010-08-03 12:44       ` Jeff King
2010-08-03 17:37         ` Joshua Juran
2010-08-03 17:49           ` Jeff King
2010-08-03 10:02     ` Jakub Narebski
2010-08-03 10:08       ` Jakub Narebski
2010-08-03 12:48       ` Jeff King
2010-08-03 13:19         ` Jakub Narebski [this message]
2010-08-03 13:20           ` Jeff King
2010-08-03 13:24             ` Michael J Gruber
2010-08-03 13:32               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008031519.11012.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=joelcsalomon@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).