From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] tests: A new test prereq for testing chmod -w as root
Date: Wed, 4 Aug 2010 15:40:15 -0500 [thread overview]
Message-ID: <20100804204015.GA2920@burratino> (raw)
In-Reply-To: <7veieefaym.fsf@alter.siamese.dyndns.org>
Hi Ævar,
Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> Some tests depend on not being able to read files after chmod -w. This
>> doesn't work when running the tests as root.
>
> Obviously you meant s/read/write/ or "chmod -r" ;-)
>
> We discussed this prerequisite in the past as "SANITY"
[...]
> Also I think there was a discussion and proposed patch to support more
> than one prerequisite tokens, concatenated with "," or something
Thanks for picking up this topic. Here’s some related work:
- Incomplete series using space-separated test prerequisites:
http://thread.gmane.org/gmane.comp.version-control.git/145427
- Why that series is incomplete:
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=104;bug=579273
- Comma-separated test prerequisites:
http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118434
- Earlier.
http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385
> test_expect_success POSIXPERM,SANITY
Last time I looked, IFS=, as used by Hannes looked like a sane
approach. I noticed too late and did not follow up; sorry about that.
next prev parent reply other threads:[~2010-08-04 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 15:00 [PATCH] tests: A new test prereq for testing chmod -w as root Ævar Arnfjörð Bjarmason
2010-08-04 19:13 ` Junio C Hamano
2010-08-04 20:30 ` Ævar Arnfjörð Bjarmason
2010-08-04 20:40 ` Jonathan Nieder [this message]
2010-08-06 22:09 ` [PATCH v2] tests: A SANITY test prereq for testing if we're root Ævar Arnfjörð Bjarmason
2010-08-09 16:55 ` Junio C Hamano
2010-08-09 19:02 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804204015.GA2920@burratino \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).