git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 1/3] test-lib: Add support for multiple test prerequisites
Date: Sat, 7 Aug 2010 21:03:33 -0500	[thread overview]
Message-ID: <20100808020332.GA11894@burratino> (raw)
In-Reply-To: <20100808015729.GA9284@burratino>

Jonathan Nieder wrote:

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -338,7 +338,7 @@ test_have_prereq () {
>  		*" $prerequisite "*)
>  			: yes, have it ;;
>  		*)
> -			! : nope ;;
> +			return 1

The ";;" is optional for the last arm in a case statement, but
it is probably simpler to include it.  Sorry about that.

(The only intended effect was only to use “return” that terminates and
propagates out of the loop instead of “false” that is overridden by a
later “true”.)

  reply	other threads:[~2010-08-08  2:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 21:19 [PATCH 0/3] tests: Better prerequisite handling & documentation Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 1/3] test-lib: Add support for multiple test prerequisites Ævar Arnfjörð Bjarmason
2010-08-08  1:57   ` Jonathan Nieder
2010-08-08  2:03     ` Jonathan Nieder [this message]
2010-08-08  9:15     ` Johannes Sixt
2010-08-08 13:29     ` Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 2/3] test-lib: Print missing prerequisites in test output Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 3/3] t/README: Document the predefined test prerequisites Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100808020332.GA11894@burratino \
    --to=jrnieder@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).