git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Asgeir S. Nilsen" <asgeir@twingine.no>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] contrib: Replaced /bin/sh with /bin/bash to make scripts with Bash syntax work on Solaris.
Date: Sat, 7 Aug 2010 22:11:42 -0500	[thread overview]
Message-ID: <20100808031142.GA20077@burratino> (raw)
In-Reply-To: <1281099365-11978-1-git-send-email-asgeir@twingine.no>

Asgeir S. Nilsen wrote:

> +++ b/contrib/ciabot/ciabot.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash

Maybe, relying on a sane $PATH:

	#!/usr/bin/env sh

Not sure what would happen on the less unixy platforms.

Relying on POSIX execlp:

	# shebang line omitted for portability

Simplest of all is to tweak the #! lines in whatever script is used to
deploy the scripts from contrib.  I would not mind seeing an
install-contrib target incorporated into the Makefile that does that.

  parent reply	other threads:[~2010-08-08  3:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-06 12:56 [PATCH] contrib: Replaced /bin/sh with /bin/bash to make scripts with Bash syntax work on Solaris Asgeir S. Nilsen
2010-08-06 16:00 ` Junio C Hamano
     [not found]   ` <AANLkTi=niNfKy0JgOG4hqNtXYQPfbkd10NRDDKM1rhfB@mail.gmail.com>
2010-08-09 16:44     ` Junio C Hamano
2010-08-10 12:33       ` Greg Troxel
2010-08-08  3:11 ` Jonathan Nieder [this message]
2010-08-09 16:57   ` Junio C Hamano
2010-08-09 20:16     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100808031142.GA20077@burratino \
    --to=jrnieder@gmail.com \
    --cc=asgeir@twingine.no \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).