From: Johannes Sixt <j6t@kdbg.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 1/3] test-lib: Add support for multiple test prerequisites
Date: Sun, 8 Aug 2010 11:15:12 +0200 [thread overview]
Message-ID: <201008081115.12444.j6t@kdbg.org> (raw)
In-Reply-To: <20100808015729.GA9284@burratino>
On Sonntag, 8. August 2010, Jonathan Nieder wrote:
> Ævar Arnfjörð Bjarmason wrote:
> > Change the test_have_prereq function in test-lib.sh to support a
> > comma-separated list of prerequisites. This is useful for tests that
> > need e.g. both POSIXPERM and SANITY.
> >
> > The implementation was stolen from Junio C Hamano and Johannes Sixt,
> > the tests and documentation were not.
>
> I think you can sell it better. :)
>
> From: Johannes Sixt <j6t@kdbg.org>
> Subject: test-lib: Allow tests with multiple prerequisites
I think the patch has changed sufficiently, particularly in the subtle points,
that authorship should not be attributed to me anymore.
Thanks for your review!
-- Hannes
next prev parent reply other threads:[~2010-08-08 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 21:19 [PATCH 0/3] tests: Better prerequisite handling & documentation Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 1/3] test-lib: Add support for multiple test prerequisites Ævar Arnfjörð Bjarmason
2010-08-08 1:57 ` Jonathan Nieder
2010-08-08 2:03 ` Jonathan Nieder
2010-08-08 9:15 ` Johannes Sixt [this message]
2010-08-08 13:29 ` Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 2/3] test-lib: Print missing prerequisites in test output Ævar Arnfjörð Bjarmason
2010-08-06 21:19 ` [PATCH 3/3] t/README: Document the predefined test prerequisites Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008081115.12444.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).