From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: Tay Ray Chuan <rctay89@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 2/2] Makefile: add missing dependency on http.h
Date: Sun, 8 Aug 2010 16:48:59 -0500 [thread overview]
Message-ID: <20100808214859.GC6962@burratino> (raw)
In-Reply-To: <20100808211910.GA7210@burratino>
v1.7.1-rc0~65^2~2 (http: init and cleanup separately from
http-walker, 2010-03-02) introduced a direct dependency from
http-fetch on the HTTP request library. Declare it.
Detected with "make CHECK_HEADER_DEPENDENCIES=1".
Cc: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
After this series, “make COMPUTE_HEADER_DEPENDENCIES=YesPlease”
succeeds again.
Ideas for future work:
- speed up the dependency checker, run it regularly;
- port COMPUTE_HEADER_DEPENDENCIES to non-gcc compilers so it can
be used by default;
- speed up the redundant-dependency detector[1] enough to make it
usable;
- autoconf test;
- “make test-makefile” for cron jobs.
Alas, this series did none of those things.
[1] <20100131231103.GA5287@progeny.tock> which doesn’t seem to
have made it out into the world. Will resend as reply.
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 9a233b0..e151516 100644
--- a/Makefile
+++ b/Makefile
@@ -1856,7 +1856,7 @@ builtin/tar-tree.o archive-tar.o: tar.h
builtin/pack-objects.o: thread-utils.h
connect.o transport.o http-backend.o: url.h
http-fetch.o http-walker.o remote-curl.o transport.o walker.o: walker.h
-http.o http-walker.o http-push.o remote-curl.o: http.h
+http.o http-walker.o http-push.o http-fetch.o remote-curl.o: http.h
xdiff-interface.o $(XDIFF_OBJS): \
xdiff/xinclude.h xdiff/xmacros.h xdiff/xdiff.h xdiff/xtypes.h \
--
1.7.2.1.544.ga752d.dirty
next prev parent reply other threads:[~2010-08-08 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 21:19 [PATCH 0/2] add missing dependencies on headers Jonathan Nieder
2010-08-08 21:25 ` [PATCH 1/2] Makefile: add missing dependencies on url.h Jonathan Nieder
2010-08-08 23:00 ` Jeff King
2010-08-08 21:48 ` Jonathan Nieder [this message]
2010-08-08 21:52 ` [PATCH/RFC 15/12] Makefile: check for unnecessary dependencies with CHECK Jonathan Nieder
2010-08-09 4:01 ` [PATCH 2/2] Makefile: add missing dependency on http.h Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100808214859.GC6962@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).