From: Jonathan Nieder <jrnieder@gmail.com>
To: Ralf Ebert <info@ralfebert.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] More readable 'Not a git repository' messages
Date: Mon, 9 Aug 2010 18:01:32 -0500 [thread overview]
Message-ID: <20100809230132.GG4429@burratino> (raw)
In-Reply-To: <i3q0d8$m8f$1@dough.gmane.org>
Ralf Ebert wrote:
> this code is inside a loop that goes up in the directory hierarchy.
> So cwd[offset] = '\0' does not only happen once before dying.
I hope not, since then the returned cwd value would be useless
for restoring the original cwd later.
Shameless plug: you may find the version in commit 98937be (i.e.
branch jn/maint-setup-fix in pu) more readable. :)
next prev parent reply other threads:[~2010-08-09 23:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 17:24 [PATCH] More readable 'Not a git repository' messages Ralf Ebert
2010-08-09 22:14 ` Nguyen Thai Ngoc Duy
2010-08-09 22:44 ` Ralf Ebert
2010-08-09 23:01 ` Jonathan Nieder [this message]
2010-08-09 23:34 ` Ralf Ebert
2010-08-10 11:31 ` Nguyen Thai Ngoc Duy
2010-08-10 2:49 ` Sverre Rabbelier
2010-08-10 15:52 ` Jared Hance
2010-08-10 22:34 ` Joshua Juran
2010-08-13 17:25 ` [PATCH/RFC v2] " Ralf Ebert
2010-08-13 17:30 ` Joshua Juran
2010-08-15 2:55 ` [PATCH] setup.c: Improve " Ralf Ebert
2010-08-15 3:36 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809230132.GG4429@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=info@ralfebert.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).