From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Stephen Boyd" <bebarino@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
git@vger.kernel.org, kernel@pengutronix.de
Subject: Re: gitweb not friendly to firefox revived
Date: Sat, 14 Aug 2010 14:33:33 +0200 [thread overview]
Message-ID: <201008141433.35451.jnareb@gmail.com> (raw)
In-Reply-To: <AANLkTimR9Wkz+YOchyjvO8fgAwk5YsGtcpMOpyZY4Fjv@mail.gmail.com>
On Sat, 14 Aug 2010, Ævar Arnfjörð Bjarmason wrote:
> 2010/8/14 Stephen Boyd <bebarino@gmail.com>:
>> On 08/03/2010 02:50 PM, Jakub Narebski wrote:
>>>
>>> +
>>> + my $title = to_utf8("Search for commits $performed by $author");
>>> + $title =~ s/[[:cntrl:]]/?/g;
>>> +
>>>
>>
>> Isn't it possible that other data coming from git could have escape
>> characters in them such as the commit subject line? In which case this same
>> bug would occur?
>>
>> Therefore isn't it better to strip out control characters (that's what this
>> patch is doing right?) in esc_html?
>
> I don't think stripping them out is the right thing either, hiding
> from you that something is Really Wrong (binary garbage in patches)
> isn't good.
>
> Something like this would be better:
>
> s/([[:cntrl:]])/sprintf("\\%03x", ord $1)/ge
Or
s|([[:cntrl:]])|quot_cec($1)|eg;
But is it worth it? This is about _title_ attribute, shown only on
mouseover (mouse hover).
But perhaps it would be worth it to add 'prep_attr' and 'esc_attr'
functions, though esc_html can be used in those places where esc_attr
would be needed...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-08-14 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 19:51 gitweb not friendly to firefox revived Uwe Kleine-König
2010-08-01 20:15 ` Ævar Arnfjörð Bjarmason
2010-08-02 5:31 ` Uwe Kleine-König
2010-08-01 20:26 ` Jakub Narebski
2010-08-03 21:07 ` Uwe Kleine-König
2010-08-03 21:50 ` Jakub Narebski
2010-08-12 9:23 ` Uwe Kleine-König
2010-08-14 10:33 ` Stephen Boyd
2010-08-14 10:48 ` Ævar Arnfjörð Bjarmason
2010-08-14 12:33 ` Jakub Narebski [this message]
2010-09-07 8:22 ` Uwe Kleine-König
2010-08-14 12:29 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008141433.35451.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).