From: Daniel Johnson <computerdruid@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Tay Ray Chuan <rctay89@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden
Date: Sat, 14 Aug 2010 17:32:05 -0400 [thread overview]
Message-ID: <201008141732.16214.ComputerDruid@gmail.com> (raw)
In-Reply-To: <AANLkTikP5xsvfBt7Rq9CoNnF=7SE4-V6LBML=tDMtT_Q@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 815 bytes --]
On Friday 13 August 2010 17:39:04 Ævar Arnfjörð Bjarmason wrote:
> On Fri, Aug 13, 2010 at 21:27, Daniel Johnson <computerdruid@gmail.com>
wrote:
> > ---
> >
> >>> @@ -0,0 +1,44 @@
> >>> +
> >>> +#!/bin/sh
> >>
> >> Is that an empty line before the test begins? The shebang should be on
> >> the first line.
> >
> > Embarrassing. That's what I get for using yank/put and not paying closer
> > attention. The rest is fixed too.
>
> Nice, I haven't actually *run it* but it looks good, so provided that
> it passes tests when our beloved maintainer applies it:
>
> Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Well, now that we have a fix and a test to help guard against future breakages,
can someone tell me the next step as to getting them included?
Thanks,
-Dan
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-08-14 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 18:56 [PATCH/RFC] fetch: allow command line --tags to override config Daniel Johnson
2010-08-05 9:56 ` Tay Ray Chuan
2010-08-06 13:54 ` [PATCH] Documentation: changes in the behavior of tagopt Daniel Johnson
2010-08-08 2:17 ` Tay Ray Chuan
2010-08-11 22:57 ` [RFC/PATCHv2] fetch: allow command line --tags to override config Daniel Johnson
2010-08-13 1:22 ` Junio C Hamano
2010-08-13 20:13 ` [RFC/PATCH] t5525: test the tagopt variable and that it can be overridden Daniel Johnson
2010-08-13 20:55 ` Ævar Arnfjörð Bjarmason
2010-08-13 21:27 ` [RFC/PATCHv2] " Daniel Johnson
2010-08-13 21:39 ` Ævar Arnfjörð Bjarmason
2010-08-14 21:32 ` Daniel Johnson [this message]
2010-08-14 21:37 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008141732.16214.ComputerDruid@gmail.com \
--to=computerdruid@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).