git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yaroslav Halchenko <debian@onerussian.com>
To: git@vger.kernel.org
Subject: wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log)
Date: Thu, 19 Aug 2010 22:01:27 -0400	[thread overview]
Message-ID: <20100820020127.GG22469@onerussian.com> (raw)

Hi Git Developers,

Shame on me but couldn't figure out if there is any official bug tracker
for git -- previously I just complained here, so keeping the tradition:

merge.log (or merge.summary) enables a really nice feature of including
a list of commits involved in the merge.  Unfortunately it is limited to
20 entries and only includes total number of included commits if that is
larger than 20.

Looking at the source code (if I got it right)

static int do_fmt_merge_msg(int merge_title, int merge_summary,
	struct strbuf *in, struct strbuf *out) {
	int limit = 20, i = 0, pos = 0;
.... no line touches limit ....
			shortlog(origins.items[i].string, origins.items[i].util,
					head, &rev, limit, out);

so, limit of 20 is hardcoded and cannot be altered via configuration.  I
would love to have it configurable, so, if desired, be set to infinity
(configuration wide or as a cmd line parameter for a specific merge).

Thanks in advance
-- 
                                  .-.
=------------------------------   /v\  ----------------------------=
Keep in touch                    // \\     (yoh@|www.)onerussian.com
Yaroslav Halchenko              /(   )\               ICQ#: 60653192
                   Linux User    ^^-^^    [175555]

             reply	other threads:[~2010-08-20  2:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20  2:01 Yaroslav Halchenko [this message]
2010-08-20  6:47 ` wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log) Ramkumar Ramachandra
2010-08-20  8:16   ` Jonathan Nieder
2010-08-20  8:36     ` Ramkumar Ramachandra
2010-08-20  9:10     ` Johannes Sixt
2010-08-20  9:19       ` Ramkumar Ramachandra
2010-08-20  9:29         ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820020127.GG22469@onerussian.com \
    --to=debian@onerussian.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).