From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Yaroslav Halchenko <debian@onerussian.com>,
git@vger.kernel.org
Subject: Re: wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log)
Date: Fri, 20 Aug 2010 14:49:28 +0530 [thread overview]
Message-ID: <20100820091925.GE12794@kytes> (raw)
In-Reply-To: <4C6E468F.3000800@viscovery.net>
Hi Johannes,
Johannes Sixt writes:
> Am 8/20/2010 10:16, schrieb Jonathan Nieder:
> > This also provides --log-limit=0 / "[merge] loglimit = 0" to not limit
> > the number of commits summarized at all, which I would expect to
> ...
> > [verse]
> > -'git fmt-merge-msg' [--log | --no-log] <$GIT_DIR/FETCH_HEAD
> > -'git fmt-merge-msg' [--log | --no-log] -F <file>
> > +'git fmt-merge-msg' [--log | --no-log] [--log-limit=<n>] <$GIT_DIR/FETCH_HEAD
> > +'git fmt-merge-msg' [--log | --no-log] [--log-limit=<n>] -F <file>
>
> Do we need --log-limit? Why not just --log=42 and --no-log equals --log=0?
>
> Ditto for the config option:
>
> merge.log=42
> merge.log=0
Ah, just when I was about to post the series. Excellent idea! I'll
drop Jonathan's patch and fixup the series to do this in a few
minutes.
> and for backwards compatibility:
>
> merge.log=false === merge.log=0
> merge.log=true === merge.log=20
I'll use git_config_bool_or_int for this -- we've traded off the
ability to say "infinite" though.
-- Ram
next prev parent reply other threads:[~2010-08-20 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 2:01 wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log) Yaroslav Halchenko
2010-08-20 6:47 ` Ramkumar Ramachandra
2010-08-20 8:16 ` Jonathan Nieder
2010-08-20 8:36 ` Ramkumar Ramachandra
2010-08-20 9:10 ` Johannes Sixt
2010-08-20 9:19 ` Ramkumar Ramachandra [this message]
2010-08-20 9:29 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820091925.GE12794@kytes \
--to=artagnon@gmail.com \
--cc=debian@onerussian.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).