From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2] git-notes: Run partial expensive test everywhere
Date: Tue, 24 Aug 2010 02:14:53 -0500 [thread overview]
Message-ID: <20100824071453.GA3064@burratino> (raw)
In-Reply-To: <AANLkTikfwbtKt2WrxzRyKHnP3ySGtBF33=z_rJwjPx5Y@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> It turns out that this fails on Solaris because its /usr/bin/time is different.
Odd. Different how? As far as I can tell, all that test asks
of time is to execv() its arguments and pass on a 0 exit status.
Ah, maybe this is it: perhaps /usr/bin/time sh runs /bin/sh. Does the
following help?
Patch is against next. Untested except on Linux where it wouldn't
make a difference.
-- 8< --
Subject: t3302 (notes): Port to Solaris
The time_notes script, which uses POSIX shell features, is
currently sometimes run with a non-POSIX /bin/sh.
Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
diff --git a/t/t3302-notes-index-expensive.sh b/t/t3302-notes-index-expensive.sh
index 7c08e99..e35d781 100755
--- a/t/t3302-notes-index-expensive.sh
+++ b/t/t3302-notes-index-expensive.sh
@@ -96,7 +96,7 @@ time_notes () {
for mode in no-notes notes
do
echo $mode
- /usr/bin/time sh ../time_notes $mode $1
+ /usr/bin/time "$SHELL_PATH" ../time_notes $mode $1
done
}
--
next prev parent reply other threads:[~2010-08-24 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 19:56 [PATCH] git-notes: Run partial expensive test everywhere Ævar Arnfjörð Bjarmason
2010-08-10 20:29 ` Sverre Rabbelier
2010-08-10 21:00 ` Ævar Arnfjörð Bjarmason
2010-08-10 21:56 ` Ævar Arnfjörð Bjarmason
2010-08-10 23:37 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-08-19 15:50 ` Ævar Arnfjörð Bjarmason
2010-08-24 7:14 ` Jonathan Nieder [this message]
2010-08-24 16:46 ` Junio C Hamano
2010-08-29 19:20 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824071453.GA3064@burratino \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).