From: Jonathan Nieder <jrnieder@gmail.com>
To: alex@chmrr.net
Cc: git@vger.kernel.org
Subject: Re: [PATCH] config: Print the delimeter of intuited --bool values under --get-regexp
Date: Thu, 26 Aug 2010 22:17:57 -0500 [thread overview]
Message-ID: <20100827031757.GD23924@burratino> (raw)
In-Reply-To: <1282855775-22582-1-git-send-email-alex@chmrr.net>
Alex Vandiver wrote:
> @@ -132,14 +129,21 @@ static int show_config(const char *key_, const char *value_, void *cb)
> must_free_vptr = 1;
> }
> else
> - vptr = value_?value_:"";
> + vptr = value_;
[...]
> if (dup_error) {
> error("More than one value for the key %s: %s",
> key_, vptr);
Could this segfault?
next prev parent reply other threads:[~2010-08-27 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 17:45 [PATCH] Test the interaction of --bool and --get-regexp on a key with no explicit value Alex Vandiver
2010-08-26 20:49 ` [PATCH] config: Print the delimeter of intuited --bool values under --get-regexp alex
2010-08-27 3:17 ` Jonathan Nieder [this message]
2010-08-27 3:15 ` [PATCH] Test the interaction of --bool and --get-regexp on a key with no explicit value Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827031757.GD23924@burratino \
--to=jrnieder@gmail.com \
--cc=alex@chmrr.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).