From: Knut Franke <k.franke@science-computing.de>
To: kusmabite@gmail.com
Cc: git@vger.kernel.org, Frank Li <lznuaa@gmail.com>
Subject: Re: [PATCH 2/2] Allow core.askpass to override SSH_ASKPASS.
Date: Fri, 27 Aug 2010 14:45:24 +0200 [thread overview]
Message-ID: <201008271445.26098.k.franke@science-computing.de> (raw)
In-Reply-To: <AANLkTik5eMLCKK7muBW9k8-0ZAxraATCs5hHVcX-Zutn@mail.gmail.com>
On Friday 27 August 2010 14:00:16 Erik Faye-Lund wrote:
> > From: Knut Franke <k.franke@science-computing.de>
>
> You don't need this line unless you're forwarding a patch for someone
> else (or using a different e-mail account).
ACK.
> > Modify handling of the 'core.askpass' option so that it has the same
> > effect as GIT_ASKPASS also if SSH_ASKPASS is set.
>
> Why are you sending a two-patch series where the second patch tries to
> correct the first one? Wouldn't it make more sense to squash the two?
a) The author of the first patch is on holiday, and I didn't want to pass off
his work as mine nor my mistakes as his. ;-)
b) Maybe not everyone agrees about the correct order of precedence.
> > diff --git a/connect.c b/connect.c
> > index e296bfc..f97b84c 100644
> > --- a/connect.c
> > +++ b/connect.c
> > @@ -627,9 +627,13 @@ char *git_getpass(const char *prompt)
> > static struct strbuf buffer = STRBUF_INIT;
> >
> > askpass = getenv("GIT_ASKPASS");
> > +
>
> Why?
Considering the check for SSH_ASKPASS added below, I believe this improves
legibilty since all of the "if (!askpass..." blocks are similar in intention.
--
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Roland Niemeier,
Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Michel Lepert
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196
next prev parent reply other threads:[~2010-08-27 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 10:51 [PATCH 2/2] Allow core.askpass to override SSH_ASKPASS Knut Franke
2010-08-27 12:00 ` Erik Faye-Lund
2010-08-27 12:45 ` Knut Franke [this message]
2010-08-27 17:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008271445.26098.k.franke@science-computing.de \
--to=k.franke@science-computing.de \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=lznuaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).