From: Jonathan Nieder <jrnieder@gmail.com>
To: Dave Olszewski <cxreg@pobox.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] push: disallow fast-forwarding tags without --force
Date: Fri, 27 Aug 2010 20:21:01 -0500 [thread overview]
Message-ID: <20100828012101.GB2004@burratino> (raw)
In-Reply-To: <alpine.DEB.2.00.1008271046080.20874@narbuckle.genericorp.net>
Hi,
Dave Olszewski wrote:
> It's trivial for someone to update build software from "git push remote
> tag" to "git push remote +tag" or "git push -f remote tag", but I can
> understand your objection.
Right. The thing to prevent is unhappy surprises: it is best if
users upgrading get a chance to update their scripts before it matters.
> It seems unlikely that many people are ever going to "flip on" this
> feature; either they won't know about it (and for them, it should be
> on), or they'll have a reason to move a tag, and want it off.
This is why a switch of some kind is useful: after reading the release
notes, a user can flip the switch for a glimpse of the future, forsee
the upcoming disaster, and fix everything up before it really matters.
After the default changes, the switch has the opposite purpose: users
who were not prepared can use it to turn back time and avoid having
to change their code.
So the deprecation process for unwanted features tends to look like
this:
1. complain about use of the feature, with an option to suppress
the warnings. or: loudly proclaim that the feature is going
away in release notes
2. add an option to disable the feature, to help people transition
3. change the default to true
4. remove the option
Step 1 is the most important one imho. See
Documentation/RelNotes-1.6.6.txt for an example.
I don't think we've ever reached step 4, but we should try it some
time.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2010-08-28 1:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 7:14 [PATCH] push: disallow fast-forwarding tags without --force Dave Olszewski
2010-08-27 17:28 ` Junio C Hamano
2010-08-27 18:01 ` Dave Olszewski
2010-08-28 1:21 ` Jonathan Nieder [this message]
2010-08-28 8:22 ` [PATCH] push: warn users about updating existing tags on push Dave Olszewski
2010-08-30 8:03 ` Junio C Hamano
2010-08-30 16:38 ` Dave Olszewski
2010-08-30 21:20 ` Junio C Hamano
2010-09-01 3:51 ` Tay Ray Chuan
2010-09-01 15:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100828012101.GB2004@burratino \
--to=jrnieder@gmail.com \
--cc=cxreg@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).