git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Marcin Cieslak <saper@saper.info>,
	Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: Odd encoding issue with UTF-8 + gettext yields ? on non-ASCII
Date: Sun, 29 Aug 2010 15:45:19 -0500	[thread overview]
Message-ID: <20100829204519.GB1890@burratino> (raw)
In-Reply-To: <AANLkTimn+-5Vys+jg=ryDfwdJ=WZfGwgZ+065M_=TF8r@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> So, my plan of attack is:
> 
>  * Add compat/printf from Free, Open or NetBSD. Maybe make
>    compat/snprintf.c use that while I'm at it.

I would prefer to get this fixed in glibc, but of course that
has nothing to do with git.

>  * Use that instead of the GNU libc printf on systems that have glibc.
>  * Add a configure check for that.
>  * Revert 107880a
>  * Get gettext goodness with LC_CTYPE
> 
> Does anyone see a problem with that? The potential issue is that
> LC_CTYPE is for:
> 
>     "regular expression matching,

should be okay, I think (unless http-backend is a problem)

> character classification,

worked around (see git-compat-util.h)

>     conversion,

I don't know what this means; iconv() is not affected by LC_CTYPE,
is it?

> case-sensitive comparison,

Could be a problem: we use strcasecmp() heavily.

> and wide character
>     functions."

no problem. :)

> So it might have unintended side-effects. But the only other
> workaround I can see is to decree that all consumers of the localized
> messages must have a UTF-8 locale.

And that is no workaround at all; the problem is still seen with UTF-8
locales, no?

  reply	other threads:[~2010-08-29 20:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 21:17 Odd encoding issue with UTF-8 + gettext yields ? on non-ASCII Ævar Arnfjörð Bjarmason
2010-08-28 21:33 ` Ævar Arnfjörð Bjarmason
2010-08-28 21:46   ` Jonathan Nieder
2010-08-28 21:59     ` Jonathan Nieder
2010-08-28 22:14       ` Marcin Cieslak
2010-08-28 22:16         ` Jonathan Nieder
2010-08-29  7:36           ` Ævar Arnfjörð Bjarmason
2010-08-29  8:37             ` Ævar Arnfjörð Bjarmason
2010-08-30  2:22             ` Jonathan Nieder
2010-08-29 18:12           ` Ævar Arnfjörð Bjarmason
2010-08-29 20:45             ` Jonathan Nieder [this message]
2010-08-30  8:57               ` Ævar Arnfjörð Bjarmason
2010-08-30 13:41                 ` Jonathan Nieder
2010-08-30 14:00                   ` Marcin Cieslak
2010-08-30 14:09                     ` Jonathan Nieder
2010-08-30 14:33                       ` Ævar Arnfjörð Bjarmason
2010-08-30 14:13                     ` Ævar Arnfjörð Bjarmason
2010-08-30 14:04                   ` Ævar Arnfjörð Bjarmason
2010-08-28 22:20         ` Jonathan Nieder
2010-08-28 22:30           ` Marcin Cieslak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100829204519.GB1890@burratino \
    --to=jrnieder@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=saper@saper.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).