git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] help.c: Pull cmd_version out of this file.
Date: Sun, 29 Aug 2010 21:40:20 -0500	[thread overview]
Message-ID: <20100830024020.GB4010@burratino> (raw)
In-Reply-To: <20100830023812.GA4010@burratino>

Jonathan Nieder wrote:
> Thiago Farina wrote:
>
>> Promote cmd_version to a builtin, by moving it to its own file
>> in builtin/version.c
[...]
> What does this make easier?

To answer my own question: it moves the code to the builtin/
subdirectory.

 $ git grep -F -e cmd_version -- builtin;	# before
 $ git grep -F -e cmd_version -- builtin;	# after
 builtin/version.c:int cmd_version(int argc, const char **argv, const char *prefix)

So for what it's worth,

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2010-08-30  2:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-29 20:44 [PATCH] help.c: Pull cmd_version out of this file Thiago Farina
2010-08-30  2:38 ` Jonathan Nieder
2010-08-30  2:40   ` Jonathan Nieder [this message]
2010-09-01  2:38     ` Thiago Farina
2010-09-01  3:04       ` Nguyen Thai Ngoc Duy
2010-09-01  3:11         ` Thiago Farina
2010-09-01  6:11       ` Junio C Hamano
2010-09-01  6:22         ` Thiago Farina
2010-09-02  1:04           ` Junio C Hamano
2010-09-02  1:16             ` Thiago Farina
2010-09-02  4:35           ` Jonathan Nieder
2010-09-02 16:31             ` Junio C Hamano
2010-10-27 15:12               ` Thiago Farina
2010-10-27 15:18                 ` Jonathan Nieder
2010-10-27 16:06                   ` Thiago Farina
2010-10-27 16:45                     ` Jonathan Nieder
2010-10-28  2:13                       ` Thiago Farina
2010-10-28  3:11                         ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830024020.GB4010@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).