git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: strk <strk@keybit.net>
To: git@vger.kernel.org
Subject: git-add creates broken submodules
Date: Mon, 30 Aug 2010 11:09:45 +0200	[thread overview]
Message-ID: <20100830090945.GB13729@keybit.net> (raw)

Hi there,
with help of doener (#git on freenode) I found
the root cause of a misconfigured git repository
being in the way 'git add <path>' behaves when 
<path> contains a .git repository.

Example:
$ (mkdir foo; cd foo; git init; git commit --allow-empty -m ini); \
  git add foo
$ git submodule status
No submodule mapping found in .gitmodules for path 'foo'

Such commit ended up in our centralized repository so that all
clones now have this 'submodule' w/out entries in .gitmodules
and .git/config.

Should 'git-add' simply consider any .git as a normal entry
instead ? (that's what I'd expect) 
Or, if not, should it warn about the presence of
a .git directory and refuse to continue suggesting
'git submodule add' instead.

NOTE: this happens with git version 1.6.0.2


--strk; 

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html

                 reply	other threads:[~2010-08-30  9:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100830090945.GB13729@keybit.net \
    --to=strk@keybit.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).