From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] merge: Make '--log' an integer option for number of shortlog entries
Date: Tue, 31 Aug 2010 09:32:36 -0500 [thread overview]
Message-ID: <20100831143236.GC2315@burratino> (raw)
In-Reply-To: <1283226800-28980-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> Change the command-line '--log' option from a boolean option to an
> integer option
What does "git merge --log=-1" do?
It looks like you have made "git fmt-merge-msg --log=-1" equivalent to
--log=20, but it might be better to error out or use INT_MAX or
something (especially because of plans to make -1 mean "infinity"
later).
Thanks for your perseverance. Aside from those two nits, the patch
looks good.
next prev parent reply other threads:[~2010-08-31 14:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 10:35 [PATCH 0/3] rr/fmt-merge-msg replacements Ramkumar Ramachandra
2010-08-28 10:35 ` [PATCH] fmt-merge-msg: Disallow '--log', 'merge.log' < 0 Ramkumar Ramachandra
2010-08-28 10:35 ` [PATCH 2/3] t6200-fmt-merge-msg: Exercise 'merge.log' to configure shortlog length Ramkumar Ramachandra
2010-08-28 10:35 ` [PATCH 3/3] t6200-fmt-merge-msg: Exercise '--log' " Ramkumar Ramachandra
2010-08-31 3:53 ` [PATCH 1/2] merge: Make '--log' an integer option for number of shortlog entries Ramkumar Ramachandra
2010-08-31 14:32 ` Jonathan Nieder [this message]
2010-08-31 18:17 ` Junio C Hamano
2010-08-31 18:21 ` Jonathan Nieder
2010-08-31 19:13 ` Ramkumar Ramachandra
2010-08-31 19:53 ` Junio C Hamano
2010-09-01 4:22 ` Ramkumar Ramachandra
2010-08-31 3:53 ` [PATCH 2/2] merge: Make 'merge.log' an integer or boolean option Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831143236.GC2315@burratino \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).