From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: [PATCH 2/2] tests: make test_must_fail fail on missing commands Date: Tue, 31 Aug 2010 11:56:53 -0400 Message-ID: <20100831155652.GB11530@sigill.intra.peff.net> References: <20100831155457.GB11014@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, gitster@pobox.com To: Jon Seymour X-From: git-owner@vger.kernel.org Tue Aug 31 17:56:49 2010 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OqTCU-0008MK-H1 for gcvg-git-2@lo.gmane.org; Tue, 31 Aug 2010 17:56:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696Ab0HaP4g (ORCPT ); Tue, 31 Aug 2010 11:56:36 -0400 Received: from xen6.gtisc.gatech.edu ([143.215.130.70]:60094 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189Ab0HaP4f (ORCPT ); Tue, 31 Aug 2010 11:56:35 -0400 Received: (qmail 28397 invoked by uid 111); 31 Aug 2010 15:56:34 -0000 Received: from 99-108-226-0.lightspeed.iplsin.sbcglobal.net (HELO sigill.intra.peff.net) (99.108.226.0) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.40) with ESMTPA; Tue, 31 Aug 2010 15:56:34 +0000 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 31 Aug 2010 11:56:53 -0400 Content-Disposition: inline In-Reply-To: <20100831155457.GB11014@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: The point of it is to run a command that produces failure. A missing command is more likely an error in the test script (e.g., using 'test_must_fail "command with arguments"', or relying on a missing command). Signed-off-by: Jeff King --- t/test-lib.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 285bfd8..dbb13af 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -598,6 +598,9 @@ test_must_fail () { elif test $exit_code -gt 129 -a $exit_code -le 192; then echo >&2 "test_must_fail: died by signal: $*" return 1 + elif test $exit_code = 127; then + echo >&2 "test_must_fail: command not found: $*" + return 1 fi return 0 } -- 1.7.2.2.119.gf9c33