From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jon Seymour <jon.seymour@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] tests: make test_must_fail fail on missing commands
Date: Tue, 31 Aug 2010 13:25:28 -0400 [thread overview]
Message-ID: <20100831172528.GA15020@sigill.intra.peff.net> (raw)
In-Reply-To: <7v7hj6d8im.fsf@alter.siamese.dyndns.org>
On Tue, Aug 31, 2010 at 09:58:09AM -0700, Junio C Hamano wrote:
> > + elif test $exit_code = 127; then
> > + echo >&2 "test_must_fail: command not found: $*"
> > + return 1
> > fi
>
> Hmm. One worry is that if we ever exit(127) ourselves this would be
> confused, but hopefully we are not that clueless.
Yeah, I considered that but dismissed it. I don't think we are that
clueless, and even if we were, then I think test_must_fail is doing a
good thing by pointing it out to us.
-Peff
next prev parent reply other threads:[~2010-08-31 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 14:49 [PATCH 0/2] fix quotes in maint-reflog-beyond-horizon and detached-stash Jon Seymour
2010-08-31 14:49 ` [PATCH 1/2] maint-reflog-beyond-horizon: fix broken test_must_fail calls Jon Seymour
2010-08-31 14:49 ` [PATCH 2/2] detached-stash: " Jon Seymour
2010-08-31 15:54 ` [PATCH 0/2] fix quotes in maint-reflog-beyond-horizon and detached-stash Jeff King
2010-08-31 15:56 ` [PATCH 1/2] tests: make test_must_fail more verbose Jeff King
2010-08-31 17:10 ` Jonathan Nieder
2010-08-31 18:06 ` Jeff King
2010-08-31 19:35 ` Jonathan Nieder
2010-09-01 3:37 ` Jon Seymour
2010-09-01 10:55 ` Ævar Arnfjörð Bjarmason
2010-08-31 15:56 ` [PATCH 2/2] tests: make test_must_fail fail on missing commands Jeff King
2010-08-31 16:58 ` Junio C Hamano
2010-08-31 17:25 ` Jeff King [this message]
2010-08-31 17:26 ` Jonathan Nieder
2010-08-31 18:08 ` Jeff King
2010-08-31 18:14 ` Ævar Arnfjörð Bjarmason
2010-08-31 17:03 ` [PATCH 0/2] fix quotes in maint-reflog-beyond-horizon and detached-stash Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831172528.GA15020@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).