From: Jonathan Nieder <jrnieder@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: 592733@bugs.debian.org, git@vger.kernel.org,
Eric Wong <normalperson@yhbt.net>
Subject: git instaweb for Debian squeeze (Re: Bug#592733: git instaweb broken)
Date: Thu, 2 Sep 2010 17:12:11 -0500 [thread overview]
Message-ID: <20100902221211.GA4789@burratino> (raw)
In-Reply-To: <20100812131152.2333.9604.reportbug@octopus.hi.pengutronix.de>
Hi again,
Uwe Kleine-König wrote:
> when I start git instaweb on a git repository, I get a crippled view
> (no style sheets, no images) that doesn't include the current project.
Ok, so the proper fix is v1.7.2-rc0~55^2~3, but that seems too dramatic
to try at the moment for squeeze (for which the plan is to basically
go with gitweb and instaweb 1.7.1). Does this workaround help?
Eric, do you think it is worth duplicating the logo and favicon within
pre-v1.7.2 instaweb? The script already takes 252 KiB, so an extra
10 KiB might not be such a big deal.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 0c6e103..95d3d0a 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -387,7 +387,11 @@ script='
s#^(my|our) \$projectroot =.*#$1 \$projectroot = "'$(dirname "$fqgitdir")'";#;
s#(my|our) \$gitbin =.*#$1 \$gitbin = "'$GIT_EXEC_PATH'";#;
s#(my|our) \$projects_list =.*#$1 \$projects_list = \$projectroot;#;
-s#(my|our) \$git_temp =.*#$1 \$git_temp = "'$fqgitdir/gitweb/tmp'";#;'
+s#(my|our) \$git_temp =.*#$1 \$git_temp = "'$fqgitdir/gitweb/tmp'";#;
+s#(my|our) \$logo =.*#$1 \$logo = "/usr/share/gitweb/git-logo.png";#;
+s#(my|our) \$favicon =.*#$1 \$favicon = "/usr/share/gitweb/git-favicon.png";#;
+s#(my|our) \$GITWEB_CONFIG_SYSTEM =.*#$1 \$GITWEB_CONFIG_SYSTEM = "";#;'
+
gitweb_cgi () {
cat > "$1.tmp" <<\EOFGITWEB
--
next parent reply other threads:[~2010-09-02 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100812131152.2333.9604.reportbug@octopus.hi.pengutronix.de>
2010-09-02 22:12 ` Jonathan Nieder [this message]
2010-09-02 22:36 ` git instaweb for Debian squeeze (Re: Bug#592733: git instaweb broken) Eric Wong
2010-09-02 23:52 ` [PATCH/RFC maint-1.7.1 0/4] instaweb 1.7.1 fixes for Debian squeeze Jonathan Nieder
2010-09-02 23:54 ` [PATCH 1/4] instaweb: ignore GITWEB_CONFIG_SYSTEM Jonathan Nieder
2010-09-03 17:23 ` Junio C Hamano
2010-09-03 18:20 ` Jonathan Nieder
2010-09-03 23:58 ` Jonathan Nieder
2010-09-04 1:36 ` Junio C Hamano
2010-09-04 2:19 ` Jonathan Nieder
2010-09-02 23:55 ` [PATCH 2/4] gitweb: skip logo in atom feed when there is none Jonathan Nieder
2010-09-02 23:56 ` [PATCH 3/4] gitweb: make logo optional Jonathan Nieder
2010-09-02 23:57 ` [PATCH 4/4] instaweb: disable logo and favicon by default Jonathan Nieder
2010-09-03 2:19 ` [PATCH v2 " Jonathan Nieder
2010-09-03 1:09 ` [PATCH/RFC maint-1.7.1 0/4] instaweb 1.7.1 fixes for Debian squeeze Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902221211.GA4789@burratino \
--to=jrnieder@gmail.com \
--cc=592733@bugs.debian.org \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).