git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: Fredrik Kuivinen <frekui@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [RFC/PATCH] Avoid TAGS/tags warning from GNU Make
Date: Sat, 4 Sep 2010 04:03:32 -0500	[thread overview]
Message-ID: <20100904090331.GA10903@burratino> (raw)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 22 Oct 2009 19:04:17 +0200

MinGW make considers the TAGS and tags targets to refer to
the same file:

 Makefile: warning: overriding commands for target `TAGS'
 Makefile: warning: ignoring old commands for target `TAGS'

Suppress both targets on that platform.

Cc: Fredrik Kuivinen <frekui@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
This is kind of ugly; I hope there is a better way.  Maybe mingw
make ought to special-case the TAGS name, since this has come up in
other projects[1], too.

[1] e.g., http://thread.gmane.org/gmane.comp.video.mplayer.devel/51542/focus=51545

 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 40fbcae..a1d4550 100644
--- a/Makefile
+++ b/Makefile
@@ -1952,6 +1952,7 @@ info:
 pdf:
 	$(MAKE) -C Documentation pdf
 
+ifeq (,$(findstring MINGW,$(uname_S)))
 TAGS:
 	$(RM) TAGS
 	$(FIND) . -name '*.[hcS]' -print | xargs etags -a
@@ -1959,6 +1960,7 @@ TAGS:
 tags:
 	$(RM) tags
 	$(FIND) . -name '*.[hcS]' -print | xargs ctags -a
+endif
 
 cscope:
 	$(RM) cscope*
-- 
1.7.2.3

             reply	other threads:[~2010-09-04  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04  9:03 Jonathan Nieder [this message]
2010-09-04  9:41 ` [RFC/PATCH] Avoid TAGS/tags warning from GNU Make Matthieu Moy
2010-09-04 16:14   ` Junio C Hamano
2010-09-04 16:34     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100904090331.GA10903@burratino \
    --to=jrnieder@gmail.com \
    --cc=frekui@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).