git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
	Tarmigan Casebolt <tarmigan+git@gmail.com>
Subject: Re: [PATCH] Add ERR support to smart HTTP
Date: Sun, 5 Sep 2010 12:41:06 -0500	[thread overview]
Message-ID: <20100905174105.GB14020@burratino> (raw)
In-Reply-To: <1283707815-32038-1-git-send-email-ilari.liusvaara@elisanet.fi>

Ilari Liusvaara wrote:

> Thus for example server response:
> 
> "0031# ERR W access for foo/alice/a1 DENIED to bob"
> 
> Will cause the following to be printed:
> 
> "fatal: remote error: W access for foo/alice/a1 DENIED to bob"
> 
> If the git version is old and doesn't support this feature, then the
> message will be:
> 
> "fatal: invalid server response; got '# ERR W access for foo/alice/a1
> DENIED to bob'"

Yippee!  Thanks, Ilari.

For this specific error, why can't gitolite use an HTTP response code?
Should http-backend be using ERR is some places, too, a la [1]?

Jonathan
who would like to find time to write a test case for "git daemon" any
day now

[1] http://thread.gmane.org/gmane.comp.version-control.git/145456/focus=145573

  reply	other threads:[~2010-09-05 17:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05 17:30 [PATCH] Add ERR support to smart HTTP Ilari Liusvaara
2010-09-05 17:41 ` Jonathan Nieder [this message]
2010-09-05 18:49   ` Ilari Liusvaara
2010-09-05 19:27     ` Ævar Arnfjörð Bjarmason
2010-09-05 21:21       ` Ilari Liusvaara
2010-09-05 21:22       ` Jakub Narebski
2010-09-06  1:04         ` Sitaram Chamarty
2010-09-06  5:45           ` Sitaram Chamarty
2010-09-06  8:45             ` Ævar Arnfjörð Bjarmason
2010-09-06  8:49             ` Jakub Narebski
2010-09-06  9:15               ` Joshua Juran
2010-09-06 14:56                 ` Shawn O. Pearce
2010-09-06 17:59                   ` Sitaram Chamarty
2010-09-06 18:19                     ` Shawn O. Pearce
2010-09-08 14:36                       ` Sitaram Chamarty
2010-09-06 14:24               ` Sitaram Chamarty
2010-09-06 16:31                 ` Jakub Narebski
2010-09-05 20:11     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905174105.GB14020@burratino \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ilari.liusvaara@elisanet.fi \
    --cc=spearce@spearce.org \
    --cc=tarmigan+git@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).